Repository navigation
Fixes #629 by expecting NoSuchElementException - #630
Merged
pekkaklarck merged 2 commits intoAug 22, 2016
Merged
pekkaklarck merged 2 commits into
pekkaklarck merged 2 commits into
Conversation
Gaurang033
pushed a commit
to Gaurang033/Selenium2Library
that referenced
this pull request
Oct 17, 2016
…amework#630) * Fixes robotframework#629 by expecting NoSuchElementException Empty expect are not coding practices. The deselect_by_value and the deselect_by_visible_text raises NoSuchElementException if it can not deselect the items.
VitoAlbano
pushed a commit
to VitoAlbano/Selenium2Library
that referenced
this pull request
Oct 18, 2016
…amework#630) * Fixes robotframework#629 by expecting NoSuchElementException Empty expect are not coding practices. The deselect_by_value and the deselect_by_visible_text raises NoSuchElementException if it can not deselect the items.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Empty expect are not coding pratices. The deselect_by_value
and the deselect_by_visible_text raises NoSuchElementException if it
can not deselect the items.
Also changed the logging from warn to info and formatted the text to
follow pep008.