Feature Request - Click Elements #585

Activity

1. aaltat commented on Jun 8, 2016

   

   aaltat

   on Jun 8, 2016

   Contributor

   More actions

   I agree that this could be handy in some occasions. Have think a name for a keyword and how would the keyword work? Would you have some examples? Also could you send a pull request so that we can see the code
2. Gaurang033 commented on Jun 9, 2016

   

   Gaurang033

   on Jun 9, 2016

   ContributorAuthor

   More actions

   Hi.

   I have code in place and I am using that as well, if you are planning to merge the code I code write few test cases for that and create a pull request in a day or two ? Do I need to open an ticket for this ?
3. aaltat commented on Jun 9, 2016

   

   aaltat

   on Jun 9, 2016

   Contributor

   More actions

   No need to open new ticket, creating pull requests should be enough.
4. Gaurang033

   added a commit that references this issue on Oct 6, 2016

   Feature Request - Click Elements robotframework#585

   f8ec2ed
5. Gaurang033 commented on Oct 11, 2016

   

   Gaurang033

   on Oct 11, 2016

   ContributorAuthor

   More actions

   @aaltat I have created the pull request for the code with my other pull request. Can you please merge the code. I was thinking to contribute more to this library however I feel, the rate of merging the code from pull request is very slow. I created the pull request in march and and then code hasn't been merged yet. :(
6. Gaurang033

   added 3 commits that reference this issue on Oct 13, 2016

   Feature Request - Click Elements robotframework#585

   340fb9e

   Feature Request - Click Elements robotframework#585

   8f63423

   Feature Request - Click Elements robotframework#585

   c6ee3e1
7. ombre42 commented on Oct 14, 2016

   

   ombre42

   on Oct 14, 2016

   Contributor

   More actions

   While I really appreciate the effort in contributing to this project, I feel that his feature is not worth the addition of a new keyword as there are already so many and I think we need to be cautious about adding new ones as it makes the library harder to use. I feel bad about that since there is already a PR out on this and I have not commented before now. The goal of this keyword is readily accomplished by what I believe to be a short and obvious combination of other keywords and syntax:

   ${elems}  Get WebElements  some_locator
   :FOR  ${elem}  IN  @{elems}
   \  Click Element  ${elem}
   

   While there are times this keyword may be really useful, there are also other keywords we could have to do similar things like Input Texts, Clear Element Texts, Click Images, Click Links, Delete Cookies, Elements Should Be Disabled, Get Texts, etc. If we had all of these and the many more I am not mentioning, it would make the library difficult to use. Surely the Selenium API is a bit too bare bones, but I do not think we want to go completely the other direction and have keywords for every possible use case.
8. emanlove commented on Oct 14, 2016

   

   emanlove

   on Oct 14, 2016

   Member

   More actions

   I second @ombre42 thoughts.
9. aaltat

   closed this as completedon Dec 21, 2016