Repository navigation
Create stubs for Flask - #2740
Merged
Merged
Conversation
ilevkivskyi
reviewed
Jan 28, 2019
ilevkivskyi
left a comment
ilevkivskyi
left a comment
Member
There was a problem hiding this comment.
I am not a Flask user, but I discovered couple hundreds possible false positives when trying these stubs with our internal codebase. 95% of them however fall into few categories below.
@JelleZijlstra @srittau Could one of you please also take a look at this PR?
ilevkivskyi
reviewed
Jan 29, 2019
ilevkivskyi
left a comment
ilevkivskyi
left a comment
Member
There was a problem hiding this comment.
This is almost ready. You just need to add the metaclass, and two comments.
Member
|
@srittau @JelleZijlstra If there are no objections, I will merge this soon, so that we can move forward. |
Closed
LarsMichelsen
added a commit
to LarsMichelsen/typeshed
that referenced
this pull request
Apr 14, 2020
…n#3913) The PR python#2740 added __setattr__ and __getattr__ to the werkzeug.wrappers.BaseRequest definition to silence mypy when monkeypatching this class. The change disabled the errors for monkeypatching, but disabled disabled the important check attr-defined.
vishalkuo
pushed a commit
to vishalkuo/typeshed
that referenced
this pull request
Jun 26, 2020
…n#3913) (python#3925) The PR python#2740 added __setattr__ and __getattr__ to the werkzeug.wrappers.BaseRequest definition to silence mypy when monkeypatching this class. The change disabled the errors for monkeypatching, but disabled disabled the important check attr-defined.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See permission in pallets/flask#2012.
Fixes #28.