Skip to content

attr-defined not working on werkzeug.wrappers.BaseRequest childs #3913

Closed

Description

@LarsMichelsen

The PR #2740 added __setattr__ and __getattr__ to the werkzeug.wrappers.BaseRequest definition.

def __setattr__(self, name: str, value: Any): ...

I have seen the comment about the change, but I cannot understand why this is a good way to go. This class is often used as parent class. No attribute checks can be made in any child class.

Can we please remove these definitions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions