You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We would be happy to accept a PR as long as the current flaks maintainers
are okay with it. Usually asking in their tracker and posting a link to a
positive response works well.
Hm, I think the best way to learn how to create stubs ATM is probably to read a bunch of existing stubs. Please do understand that stubgen doesn't infer argument types except if there's a default, so you should add those manually. Also, there's no way to test that the stubs you create match the real flask library -- the way to assess that is typically to add annotations to a mid-size app using flask and to verify that the app both runs correctly and type-checks cleanly.
Reacted by Robin Skahjem-Eriksen, Niklas Mischkulnig, Eric Arellano, Charles Heckroth, Sean Cascketta, Albert Wang, Thomas Schaper, Lukas Juhrich, Max Block and mbarkhau
Would be nice to have Flask stubs ! Any progress on this ?
Reacted by Austin McConnell, Garrett Credi, Eddie Antonio Santos, Iridium Szreter, Xavier, Daniele Teti, Michal Šimon, Lukas Juhrich, Dmitry Gening, Alexey Vyskubov and 25 more
Activity
mliubchych commentedon Jun 18, 2016
Is there any progress for this issue? Any help is needed?
zoidyzoidzoid commentedon Aug 20, 2016
Additional offer to help.
zoidyzoidzoid commentedon Aug 20, 2016
Should I start working on a PR maybe, and mitsuhiko or @pallets folk can take a look at it?
gvanrossum commentedon Aug 20, 2016
We would be happy to accept a PR as long as the current flaks maintainers
are okay with it. Usually asking in their tracker and posting a link to a
positive response works well.
--Guido (mobile)
rowillia commentedon Sep 7, 2016
Flask folks gave permission here - pallets/flask#2012
gvanrossum commentedon Sep 7, 2016
zoidyzoidzoid commentedon Sep 9, 2016
I've started working on it, and will happily accept PRs or any input: https://github.com/zoidbergwill/typeshed
Is there any documentation on tips on creating new stubs?
I've used
stubgen, and am working on each file one by one now.gvanrossum commentedon Sep 9, 2016
Hm, I think the best way to learn how to create stubs ATM is probably to read a bunch of existing stubs. Please do understand that stubgen doesn't infer argument types except if there's a default, so you should add those manually. Also, there's no way to test that the stubs you create match the real flask library -- the way to assess that is typically to add annotations to a mid-size app using flask and to verify that the app both runs correctly and type-checks cleanly.
zoidyzoidzoid commentedon Sep 9, 2016
Awesome, thanks. Browsing all the existing stubs in this repo have been how I've been figuring it out so far.
Thanks, will try that out. I have some Flask apps with some annotation coverage which I'll improve and then test it on.
rowillia commentedon Sep 9, 2016
@zoidbergwill I've got a PR open that adds stubs to werkzeug - #530
Add stubs for itsdangerous.
zoidyzoidzoid commentedon Sep 15, 2016
Thanks @rowillia Should I wait and then reuse some of your new types you're adding?
Add stubs for itsdangerous. (#537)
octylFractal commentedon Jun 26, 2017
Any progress on this? I'd like to use these.
zoidyzoidzoid commentedon Jun 26, 2017
I started work on it here ages ago, but the tooling for starting a fresh stub might have improved since then.
TimotheeJeannin commentedon May 7, 2018
Would be nice to have Flask stubs ! Any progress on this ?
Create stubs for Flask (#2740)
ilevkivskyi commentedon Feb 11, 2019
@vivaldus
Have you noticed that this issue is closed? The stubs were added couple weeks ago and actually went into the latest mypy release.
But more importantly, what was the purpose of this comment?