Skip to content

email.charset is too restrictively stubbed #2767

Closed
Closed
email.charset is too restrictively stubbed#2767

Description

@joshuamorton
joshuamorton
opened on Jan 25, 2019

There are two issues I noticed with the python3 stubs for email.charset.

  1. add_charset takes Union[str, Charset]`, not just charset

  2. Some module level constants like QP and BASE64 are not stubbed. They're also not available in __all__, but are necessary for idiomatic use of the add_charset function.

(PR to fix these issues to follow shortly)

Activity

  1. srittau
    closed this as completedin #2768on Feb 9, 2019
  2. srittau
    added a commit that references this issue on Feb 9, 2019

    Improve the stubs in charset.pyi under python3. (#2768)

    b0eb6c2
  3. joshuamorton
    added a commit that references this issue on Apr 8, 2019

    Add six.moves types form email_mime sources.

    e16748c
  4. srittau
    added a commit that references this issue on Apr 8, 2019

    Add six.moves types for email_mime sources. (#2902)

    d46d36b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions