Repository navigation
Add six.moves types for email_mime sources. - #2902
Merged
Merged
Conversation
added 2 commits
April 8, 2019 08:26
As a followup to the work done in python#2767 and python#2830, and to address a piece of python#66, most of the email_mime submodules aren't typed in six under python2, only python3. Now they are.
It looks like internally the stdlib typeshed reflects the python3 source layout, and the python2 imports are dynamically generated. Stubs now reflect that.
srittau
requested changes
Apr 8, 2019
srittau
left a comment
srittau
left a comment
Collaborator
There was a problem hiding this comment.
Unfortunately, the imports you use do not exist yet as stubs, since email is also incomplete. You either need to fix that (by importing the modules in stdlib/2/email/__init__.pyi or import the more modern modules in six, e.g. email.mime.multipart, which do exist as stubs.
Contributor
Author
|
Should be fixed now. Although I guess I don't need six at all, since this means I can import from the new paths in py2 and py3. Good to know :) |
srittau
approved these changes
Apr 8, 2019
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a followup to the work done in #2767 and #2830, and to address a
piece of #66, most of the email_mime submodules aren't typed in six
under python2, only python3. Now they are.