Repository navigation
Improve the stubs in charset.pyi under python3. - #2768
Merged
Merged
Conversation
added 2 commits
January 25, 2019 11:36
The python3 charset stubs didn't include certain necessary module level constansts (like `QP`) and too-tightly defined the arguments to some of the functions in the module. This is no longer the case.
On a second look, add_charset only accepts a string, it doesn't stringify the accepted object, so a Charset won't function correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The python3 charset stubs didn't include certain necessary module level
constansts (like
QP) and too-tightly defined the arguments to some ofthe functions in the module. This is no longer the case.
Fixes #2767.