Repository navigation
first pass at fixing - #124
Merged
Merged
Conversation
civsiv
commented
Apr 28, 2021
| // Response OrderItems must be updated into supplied orderItemContexts (including duplicates for multi-party booking) | ||
|
|
||
| using (var db = FakeBookingSystem.Database.Mem.Database.Open()) | ||
| var query = orderItemContexts.Select((orderItemContext) => |
Contributor
Author
There was a problem hiding this comment.
This has been refactor to call a function on FakeDatabase instead of manipulating the tables from here
civsiv
commented
Apr 28, 2021
| } | ||
| }, | ||
| Activity = new List<Concept> | ||
| var getOccurrenceInfoResult = FakeBookingSystem.Database.GetOccurrenceAndBookedOrderItemInfoIfRelevantBySlotId(flowContext.OrderId.uuid, orderItemContext.RequestBookableOpportunityOfferId.SlotId); |
Contributor
Author
There was a problem hiding this comment.
This call has the database logic
civsiv
commented
Apr 28, 2021
| }, | ||
| Activity = new List<Concept> | ||
| var getOccurrenceInfoResult = FakeBookingSystem.Database.GetOccurrenceAndBookedOrderItemInfoIfRelevantBySlotId(flowContext.OrderId.uuid, orderItemContext.RequestBookableOpportunityOfferId.SlotId); | ||
| if (getOccurrenceInfoResult.Item1 == FakeDatabaseGetOccurrenceAndBookedOrderItemInfoResult.OccurrenceWasNotFound) |
Contributor
Author
There was a problem hiding this comment.
Destructure this, don't use Item1
civsiv
commented
Apr 28, 2021
| EndDate = (DateTimeOffset)slot.End, | ||
| MaximumUses = slot.MaximumUses, | ||
| // Exclude current Order from the returned lease count | ||
| RemainingUses = slot.RemainingUses - db.Count<OrderItemsTable>( |
Contributor
Author
There was a problem hiding this comment.
Make this into another db call that returns number of remaining uses minus leases
civsiv
commented
Apr 28, 2021
|
|
||
| private static void AddPropertiesToBookedOrderItem(OrderItemContext<FacilityOpportunity> ctx, BookedOrderItemInfo bookedOrderItemInfo, StoreBookingFlowContext flowContext) | ||
| { | ||
| ctx.SetOrderItemId(flowContext, bookedOrderItemInfo.OrderItemId); |
Contributor
Author
There was a problem hiding this comment.
Remove this as it's already set
civsiv
commented
Apr 28, 2021
| } | ||
| } | ||
|
|
||
| private static void AddPropertiesToBookedOrderItem(OrderItemContext<FacilityOpportunity> ctx, BookedOrderItemInfo bookedOrderItemInfo, StoreBookingFlowContext flowContext) |
Contributor
Author
There was a problem hiding this comment.
Abstract this out and make generic
civsiv
commented
Apr 28, 2021
|
|
||
|
|
||
| return ( | ||
| FakeDatabaseGetOccurrenceAndBookedOrderItemInfoResult.OccurrenceAndBookedOrderItemInfoSuccessfullyGot, |
Contributor
Author
There was a problem hiding this comment.
Rename to be shorter
civsiv
commented
Apr 28, 2021
| } | ||
| } | ||
|
|
||
| public (FakeDatabaseGetOccurrenceAndBookedOrderItemInfoResult, FacilityUseTable, SlotTable, BookedOrderItemInfo) GetOccurrenceAndBookedOrderItemInfoIfRelevantBySlotId(string uuid, long? slotId) |
Contributor
Author
There was a problem hiding this comment.
Rename to Slot not Occurrence
civsiv
commented
Apr 28, 2021
| ImageUrl = orderItem.ImageUrl, | ||
| BarCodeText = orderItem.BarCodeText, | ||
| MeetingId = orderItem.MeetingId, | ||
| MeetingPassword = orderItem.MeetingPassword, |
Contributor
Author
There was a problem hiding this comment.
Meeting* fields do not exist for facilities
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Waiting on #131 to merge as it will fix the CI issues with this PR