Repository navigation
feat: OrderProposal RPDE feed - #131
Merged
Merged
Conversation
nickevansuk
force-pushed
the
coverage/order-proposals-rpde-feed
branch
from
April 29, 2021 10:48
2d1be83 to
aee5259
Compare
Merged
civsiv
reviewed
Apr 29, 2021
| throw new OpenBookingException(new InternalLibraryError(), "SetOrderItemId must be called for each OrderItemContext in ProposeOrderItems"); | ||
| } | ||
|
|
||
| // Set the orderItemStatus to be https://openactive.io/OrderItemProposed (as it must always be so in the response of P) |
Contributor
There was a problem hiding this comment.
Why null instead of OrderItemProposed ?
Contributor
Author
There was a problem hiding this comment.
Good question: openactive/open-booking-api#157
civsiv
approved these changes
Apr 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per openactive/open-booking-api#197