Skip to content

After P -> A -> B flow, OrderItems in B response are missing various properties including accessPass #120

Open

Description

@lukehesluke

Missing fields

  • position
  • (for virtual sessions)
    • accessChannel
    • customerNotice
  • (for physical sessions)
    • accessPass
    • accessCode
  • (not OrderItems but the Orders themselves):
    • totalPaymentTax (i haven't checked for all of them, but I can confirm that this was available in P's response - just not B. I expect they're all like that)
    • customer.identifier (it seems like all Customer fields excepting @type and email are missing from the B-after-P response)
    • customer.familyName
    • customer.givenName
    • customer.telephone
    • payment (therefore, payment reconcilliation tests fail)

An example failing test output:

access-channel_includes-access-channel-or-customer-notice_OpenBookingApprovalFlow_ScheduledSession.md

This error:

* ❌️ should include an `accessChannel` or a `customerNotice`
    - TypeError: Cannot read property 'accessChannel' of undefined

is because the test looks for OrderItem with position: 0 and it does not find it. The result has no position.

However, it also would have failed even still as the result has neither an accessChannel or a customerNotice - at least one of which is expected

This makes the following tests fail in Approval mode:

  • includes-access-channel-or-customer-notice
  • manual-access-codes
  • access-barcode-seller
  • access-pass-image
  • access-code-update-notifications
  • access-pass-update-notifications
  • customer-notice-notification
  • business-to-business-tax-calculation-net
  • business-to-consumer-tax-calculation-net
  • fail-outside-window
  • succeed-within-window
  • atomic-cancel
  • book-and-cancel
  • patch-contains-excessive-properties-error
  • patch-not-allowed-on-property-error
  • ...and some more

Activity

  1. lukehesluke commented on Apr 27, 2021

    @lukehesluke
    ContributorAuthor

    I've added totalPaymentTax and customer.* fields to the missing properties above. Not sure if they're part of the same bug or something else

  2. changed the title [-]After P -> A -> B flow, OrderItems in B response are missing various properties including `position`[/-] [+]After P -> A -> B flow, OrderItems in B response are missing various properties including `accessPass`[/+] on Apr 27, 2021
  3. lukehesluke commented on Apr 27, 2021

    @lukehesluke
    ContributorAuthor

    And I've removed position because it is correct that B-after-P does not return positions (openactive/open-booking-api#196)

  4. lukehesluke commented on Apr 27, 2021

    @lukehesluke
    ContributorAuthor

    Just added payment to the missing properties

  5. civsiv commented on Apr 29, 2021

    @civsiv
    Contributor

    Access fields covered by #124

  6. civsiv commented on Apr 30, 2021

    @civsiv
    Contributor

    Order field covered by #133

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

approval-flowNeeded for Approval Flow to work across test

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions