Repository navigation
Conversation
Allow running tests in subdirectories of test/parallel. Split up most tests in test/parallel into reasonable subdirectories. Fixes: nodejs#6217
|
Can you split the commit? Moving files to different directories as a commit and the Python changes necessary as another one |
|
@thefourtheye perhaps hold off spending extra time until there's a consensus this |
|
@jbergstroem Sure. |
|
Yes, happy to split it up once it's decided that this should be done. (Also rebase, etc.) |
|
Reminder to self :
|
7da4fd4 to
c7066fb
Compare
|
Looks like a good idea, but PR and discussion has stalled. Can we reach consensus? /ping @bengl still interested in pushing this effort forward? |
|
I don't have a strong opinion either way on this one, but I know that there are people who still feel like they deal with fallout from the move from |
|
My beef was mostly with GitHub not displaying test/ correctly is a much less compelling reason to split up everything again, IMO. Report it to GH and have them fix it instead of trying to work around it. |
Unless you are talking about the log of directories, you can do |
|
I know, I have log.follow set in my .gitconfig, but that only works for a single file. |
c133999 to
83c7a88
Compare
|
Gonna close this since if we do it, it should probably just be redone. |
|
Fwiw, I'd still really like to see this happen |
Checklist
Affected core subsystem(s)
test
Description of change
Allow running tests in subdirectories of test/parallel. Currently it only works on
test/parallel, but it could be changed to work in other directories. (Done intest/testpy/__init__.py.)Split up most tests in test/parallel into reasonable subdirectories. There are some stragglers that didn't seem to make sense in subdirs, but I'm happy to change that if desired.
Fixes: #6217 (If it's decided that this is worth doing.)