Repository navigation
question: can I tree-factor test/parallel #706
Description
I'm asking here before opening a PR in core...
Is there some build voodoo around test/parallel? This directory currently hold 1323 files, which causes my IDE to stutter and even GitHub borks.
Can I tree-factor it to subdirectories by subsystem so that we'll have:
test/parallel/
|
-> arm/
|
-> assert/
|
-> async-wrap/
...
Activity
gibfahn commentedon Apr 30, 2017
It's listed here: https://github.com/nodejs/node/blob/master/tools/test.py#L1559, any special casing will be done in
tools/test.py.All our tests are currently in
test/*(i.e. only one directory deep). Not sure what you mean bytree-factor, are you talking about havingtest/sequential/buffer/andtest/sequential/fs? If so why? There are only 40 tests in sequential, there doesn't seem to be much point to moving tests around and adding complexity. Moving things has been done in the past, but it generates a load of churn, so is normally done sparingly.In any case, I don't think there's anything build specific that requires that layout, but I suspect
test.pyprobably does.[-]question: can I tree-factor `test/sequential`[/-][+]question: can I tree-factor `test/parallel`[/+]refack commentedon Apr 30, 2017
@gibfahn I ment
test/parallel.Thank. I'll try a little bit and adjust
test.pyto make sure it works.gibfahn commentedon Apr 30, 2017
parallelwill be special-cased, astools/test.py -j4will only run 4 at a time for the parallel test suite.I think breaking it up was proposed before and didn't happen, it might be having a look for previous discussions before going down that road again.
refack commentedon Apr 30, 2017
I can tell
test.pythat it's a single suite, just a two dirs deep.Anyway I'll try too look up the previous discussions.
joaocgreis commentedon May 1, 2017
Ref: nodejs/node#6230
maclover7 commentedon Feb 13, 2018
I think this is an issue for nodejs/node, going to close in favor of discussion there.