Skip to content

split test/parallel into subsystem folders #6217

Closed

Description

@Fishrock123

The /parallel/ tests directory is pretty huge, with 1010 tests at the time of writing.
So large, that GitHub has begun truncating it. And, it is pretty hard to scroll though to find something (depending on your editor of choice).

screen shot 2016-04-15 at 10 08 02 am

Perhaps we should split it into actual subsystem folders? Does the test runner allow for that?

It would be a bit of a headache again though, like when we moved /simple/ to /parallel/..

cc @nodejs/testing & @nodejs/ctc

Activity

  1. added
    testIssues and PRs related to Node.js core tests and test infrastructure.
    metaIssues and PRs related to the general management of the project.
    on Apr 15, 2016
  2. jasnell commented on Apr 15, 2016

    @jasnell
    Member

    Definite +1 on this, it's getting rather difficult to manage. Not sure if
    the test runner supports it but would be easy to test. Definite headache
    but worth doing.
    On Apr 15, 2016 7:31 AM, "Jeremiah Senkpiel" notifications@github.com
    wrote:

    The /parallel/ tests directory is pretty huge, with 1010 tests at the
    time of writing.
    So large, that GitHub has begun truncating it. And, it is pretty hard to
    scroll though to find something (depending on your editor of choice).

    [image: screen shot 2016-04-15 at 10 08 02 am]
    https://cloud.githubusercontent.com/assets/1093990/14564529/f22f91d6-02f4-11e6-9376-8ded16d523be.png

    Perhaps we should split it into actual subsystem folders? Does the test
    runner allow for that?

    It would be a bit of a headache again though, like when we moved /simple/
    to /parallel/..

    cc @nodejs/testing https://github.com/orgs/nodejs/teams/testing &
    @nodejs/ctc https://github.com/orgs/nodejs/teams/ctc

    —
    You are receiving this because you are on a team that was mentioned.
    Reply to this email directly or view it on GitHub
    #6217

  3. evanlucas commented on Apr 15, 2016

    @evanlucas
    Contributor

    I like it +1 from me

  4. bengl commented on Apr 15, 2016

    @bengl
    Member

    I've got this working. Just need to fix the relative URLs in tests. PR coming soon.

  5. indutny commented on Apr 15, 2016

    @indutny
    Member

    What is a main difficulty of managing it? (Note: I'm +0 myself so far, so would appreciate to learn some arguments)

  6. trevnorris commented on Apr 15, 2016

    @trevnorris
    Contributor

    I don't see the need to change the current directory structure besides accommodating github. Am ±0 on whether this is important enough to warrant changing the entire structure again. except in a way that makes backporting tests more annoying.

  7. evanlucas commented on Apr 15, 2016

    @evanlucas
    Contributor

    oooo that's a good point @trevnorris.

  8. calvinmetcalf commented on Apr 29, 2016

    @calvinmetcalf
    Contributor

    so this also has problems in some test editors, e.g. atom doesn't do awesome with that folder

  9. Trott commented on Jul 7, 2017

    @Trott
    Member

    This issue has been inactive for sufficiently long that it seems like perhaps it should be closed. Feel free to re-open (or leave a comment requesting that it be re-opened) if you disagree. I'm just tidying up and not acting on a super-strong opinion or anything like that.

    FWIW, the implementation in #6230 got some mixed reactions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    discussIssues opened for discussion and feedback.metaIssues and PRs related to the general management of the project.testIssues and PRs related to Node.js core tests and test infrastructure.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions