Skip to content

fs: fix ENOENT on file deletion - #52571

Closed
avivkeller wants to merge 1 commit into
nodejs:mainfrom
avivkeller:patch-11
Closed

fs: fix ENOENT on file deletion#52571
avivkeller wants to merge 1 commit into
nodejs:mainfrom
avivkeller:patch-11

Conversation

@avivkeller

@avivkeller avivkeller commented Apr 17, 2024

Copy link
Copy Markdown
Member

Fixes #49995

Wraps the statSync call in a try { ... } catch { ... } block; if the failure is ENOENT, it treats the file as deleted.

@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to file-system APIs and the fs module. needs-ci PRs that need a full CI run. labels Apr 17, 2024
@MoLow

MoLow commented Apr 18, 2024

Copy link
Copy Markdown
Member

this seems like a duplication of #52349 CC @mcollina

@MoLow MoLow linked an issue Apr 18, 2024 that may be closed by this pull request
Recursive fs.watch crashes on Linux when deleting files #52018
Closed
@avivkeller

avivkeller commented Apr 18, 2024

Copy link
Copy Markdown
Member Author

Yup, it seems a like a duplicate, my bad!

@avivkeller avivkeller closed this Apr 18, 2024
@avivkeller
avivkeller deleted the patch-11 branch April 18, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

fs Issues and PRs related to file-system APIs and the fs module. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Recursive fs.watch crashes on Linux when deleting files fs.watch recursive throws on file removal

3 participants

@avivkeller @MoLow @nodejs-github-bot