Recursive fs.watch crashes on Linux when deleting files

Version

v21.7.0

Platform

Linux ARCH-FS 6.7.8-arch1-1 #1 SMP PREEMPT_DYNAMIC Sun, 03 Mar 2024 00:30:36 +0000 x86_64 GNU/Linux

Subsystem

fs

What steps will reproduce the bug?

Run the following code on Linux:

const fs = require('fs')

try {
  fs.mkdirSync('./parent/child', { recursive: true })
} catch (e) {
  console.error(e)
}

fs.writeFileSync('./parent/child/test.tmp', 'test')

fs.watch('./parent', { recursive: true }, (eventType, filename) => {
  console.log(eventType, filename)
})

fs.rmSync('./parent/child/test.tmp')

How often does it reproduce? Is there a required condition?

No response

What is the expected behavior? Why is that the expected behavior?

Emit a watcher event

What do you see instead?

Error: ENOENT: no such file or directory, stat '/home/maksis/parent/child/test.tmp'
    at statSync (node:fs:1659:25)
    at FSWatcher.<anonymous> (node:internal/fs/recursive_watch:160:28)
    at FSWatcher.emit (node:events:519:28)
    at FSWatcher._handle.onchange (node:internal/fs/watchers:215:12) {

Additional information

No response

I've been getting this same error when watching a /parent directory and deleting a subdirectory that contains files.

@mcollina

I believe #51406 introduced this behavior, the FSWatch emit callback try to acquire the stat of the deleted file

node/lib/internal/fs/recursive_watch.js

Line 160 in 1264414

const currentStats = statSync(file);

can you take a look? @mcollina

fs: fixes recursive fs.watch crash on Linux when deleting files

Here is the fix #52349

I have just being hit with this bug as well for node 20. Was the fix merged? And if not, what version will this fix be included?

fs: fixes recursive fs.watch crash on Linux when deleting files

@mcollina

@mcollina this is also a bug in v20.12, will this be backported to that or just for v22+?

it should be backported

fs: fixes recursive fs.watch crash on Linux when deleting files

Navigation Menu

Repository navigation

Recursive fs.watch crashes on Linux when deleting files #52018

Version

Platform

Subsystem

What steps will reproduce the bug?

How often does it reproduce? Is there a required condition?

What is the expected behavior? Why is that the expected behavior?

What do you see instead?

Additional information

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Recursive fs.watch crashes on Linux when deleting files #52018

Description

Version

Platform

Subsystem

What steps will reproduce the bug?

How often does it reproduce? Is there a required condition?

What is the expected behavior? Why is that the expected behavior?

What do you see instead?

Additional information

Activity

phyreman commented on Mar 23, 2024

kylo5aby commented on Mar 26, 2024

mcollina commented on Apr 3, 2024

joscarras commented on Apr 18, 2024

aLooseGoose commented on Apr 30, 2024

mcollina commented on Apr 30, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions