Repository navigation
fs.watch recursive throws on file removal #49995
Description
Details
Using fs.watch to recursively watch a directory.
After deleting a file under the directory the watcher throws:
node:internal/process/promises:288
triggerUncaughtException(err, true /* fromPromise */);
^
[Error: ENOENT: no such file or directory, open 'C:\Users\DELL\Desktop\DEV\fabric.js\e2e\tests\template\index.ts'] {
errno: -4058,
code: 'ENOENT',
syscall: 'open',
path: 'C:\\Users\\DELL\\Desktop\\DEV\\fabric.js\\e2e\\tests\\template\\index.ts'
}
Node.js v18.17.0Expected it not to throw but to call the watcher callback with the path of the deleted file with event type removed or something of the likes
Node.js version
18.17.0
Example code
const watcher = watch(
src,
{ recursive: true, persistent: true },
(type, filename) => {
console.log({ filename });
const file = path.join(src, filename);
}
);
Operating system
Windows 10 64 bit
Scope
code
Module and version
fs
Activity
fix watching
ci(e2e): fix babel compiling error (#9388)
benjamingr commentedon Oct 1, 2023
Hey I moved it here since it seems like a bug report.
cc @nodejs/fs
ShaMan123 commentedon Oct 1, 2023
Thanks
nathannorthcutt commentedon Apr 17, 2024
I get the same issue both on my local WSL (5.15.146.1-microsoft-standard-WSL2) as well as CI runner (Linux). Looks like the problem stems from
https://github.com/nodejs/node/blob/main/lib/internal/fs/recursive_watch.js#L160
const currentStats = statSync(file);statSyncby default throws an error if there is no entry providedhttps://github.com/nodejs/node/blob/main/lib/fs.js#L1654
function statSync(path, options = { bigint: false, throwIfNoEntry: true }) {Still digging into the difference between this and the non-recursive file system watcher but seems to affect multiple OS versions and not just Windows. Not in a good place to build and test node locally to verify atm but thought I'd throw that out there in case someone else can get to it first.
benjamingr commentedon Apr 17, 2024
@redyetidev this seems reasonably scoped
avivkeller commentedon Apr 17, 2024
Thanks! I'll take a look!
avivkeller commentedon Apr 17, 2024
Yes! I see the issue, I'll figure out why fs stat is being called
MoLow commentedon Apr 18, 2024
Closing as duplicate of #52018