Skip to content

feat: add Erbium tag to 12.x, reassign lts tag from 10.x to 12.x - #1134

Merged
SimenB merged 1 commit into
nodejs:masterfrom
knksmith57:tag-erbium-lts
Oct 22, 2019
Merged

SimenB merged 1 commit into
nodejs:masterfrom
knksmith57:tag-erbium-lts

Conversation

@knksmith57

Copy link
Copy Markdown
Contributor

@knksmith57

Copy link
Copy Markdown
Contributor Author

note, this has to land after #1132 to ensure >= 12.13.0 is marked as LTS and not 12.12.0

@knksmith57

Copy link
Copy Markdown
Contributor Author

also note that, until tomorrow when the first 13.x release goes out, 12.x is also still current and latest (iiuc).

I'm happy to spin a follow up PR to handle reassigning those labels once the release is available.

@nschonni

Copy link
Copy Markdown
Member

Is it better to hold this one off till tomorrow and include 13? Or is that just as confusing since 12.13.0 was merged

@knksmith57

Copy link
Copy Markdown
Contributor Author

IMO it's worth shipping this to maintain the predicate that LTS releases are available by their codename tag.

I don't think it'd be the end of the world if there was a 24 hour delay, but it does seem like, if the LTS release is available on the hub (which it soon will be), people will see the other codename tags (carbon, dubnium), and might be confused to see 12.13.0 but not erbium.

totally OK with me either way tho --just my $0.02 😄

@LaurentGoderre

Copy link
Copy Markdown
Member

I vote for merging separably from the Node 13 version.

@SimenB
SimenB merged commit 1145838 into nodejs:master Oct 22, 2019
@SimenB

SimenB commented Oct 22, 2019

Copy link
Copy Markdown
Member

Didn't trigger a PR... https://travis-ci.com/nodejs/docker-node/jobs/248296372
Will be sent when #1135 is merged

@PeterDaveHello

Copy link
Copy Markdown
Member

hmmmm, the trigger is for Dockerfile only, generate-stackbrew-library.sh changes need manual PRs.

@PeterDaveHello

Copy link
Copy Markdown
Member

Should be improved here for future changes like this one: #1136

@knksmith57

Copy link
Copy Markdown
Contributor Author

awesome, thanks for updating that, @PeterDaveHello 😄 🙏

@PeterDaveHello

Copy link
Copy Markdown
Member

No problem @knksmith57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants