Repository navigation
feat: add Erbium tag to 12.x, reassign lts tag from 10.x to 12.x - #1134
Conversation
knksmith57
commented
Oct 21, 2019
- https://nodejs.org/en/blog/release/v12.13.0/
|
note, this has to land after #1132 to ensure >= 12.13.0 is marked as LTS and not 12.12.0 |
|
also note that, until tomorrow when the first 13.x release goes out, 12.x is also still I'm happy to spin a follow up PR to handle reassigning those labels once the release is available. |
|
Is it better to hold this one off till tomorrow and include 13? Or is that just as confusing since 12.13.0 was merged |
|
IMO it's worth shipping this to maintain the predicate that LTS releases are available by their codename tag. I don't think it'd be the end of the world if there was a 24 hour delay, but it does seem like, if the LTS release is available on the hub (which it soon will be), people will see the other codename tags (carbon, dubnium), and might be confused to see 12.13.0 but not erbium. totally OK with me either way tho --just my $0.02 😄 |
|
I vote for merging separably from the Node 13 version. |
|
Didn't trigger a PR... https://travis-ci.com/nodejs/docker-node/jobs/248296372 |
|
hmmmm, the trigger is for Dockerfile only, generate-stackbrew-library.sh changes need manual PRs. |
|
Should be improved here for future changes like this one: #1136 |
|
awesome, thanks for updating that, @PeterDaveHello 😄 🙏 |
|
No problem @knksmith57 |