Skip to content

Add node.js v13.0.0 with Yarn v1.19.1 - #1135

Merged
PeterDaveHello merged 1 commit into
nodejs:masterfrom
PeterDaveHello:Node.js_v13
Oct 22, 2019
Merged

Add node.js v13.0.0 with Yarn v1.19.1#1135
PeterDaveHello merged 1 commit into
nodejs:masterfrom
PeterDaveHello:Node.js_v13

Conversation

@PeterDaveHello

@PeterDaveHello PeterDaveHello commented Oct 22, 2019

Copy link
Copy Markdown
Member

SimenB
SimenB approved these changes Oct 22, 2019
View reviewed changes

@SimenB SimenB left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update generate-stackbrew-library.sh?

Comment thread 13/alpine/Dockerfile Outdated
@SimenB SimenB mentioned this pull request Oct 22, 2019
Merged
@ljharb

This comment has been minimized.

Sign in to view
@PeterDaveHello

This comment has been minimized.

Sign in to view
@PeterDaveHello
PeterDaveHello merged commit 4fac70c into nodejs:master Oct 22, 2019
@tvainika

tvainika commented Oct 22, 2019

Copy link
Copy Markdown
Contributor

Is it really meaningful to add Nodejs 13 with Debian oldstable (strech) combination as new image variant?

Both for convenience of maintenance and easy end-of-life for Debian oldstable in the future it would be better to not add such combination anymore...

@PeterDaveHello

PeterDaveHello commented Oct 22, 2019

Copy link
Copy Markdown
Member Author

Nice catch, maybe we will prevent that in the future!

@tvainika

tvainika commented Oct 22, 2019

Copy link
Copy Markdown
Contributor

Nice catch, maybe we will prevent that in the future!

I wanted to comment it now as it is still possible to not to publish node:13-stretch tag. As far as I can see, there is no PR that would publish those as official image repository here https://github.com/docker-library/official-images/pulls

@PeterDaveHello

PeterDaveHello commented Oct 22, 2019

Copy link
Copy Markdown
Member Author

I'm not sure, I need to check the release schedule of Debian later, we can see if other @nodejs/docker members will suggest to remove it or not during this period.

@nodejs-github-bot nodejs-github-bot mentioned this pull request Oct 22, 2019
Merged
@nodejs-github-bot

nodejs-github-bot commented Oct 22, 2019

Copy link
Copy Markdown
Collaborator

Created PR to the official-images repo (docker-library/official-images#6841)

@nschonni nschonni mentioned this pull request Oct 23, 2019
Closed
@PeterDaveHello
PeterDaveHello deleted the Node.js_v13 branch October 23, 2019 06:33
PeterDaveHello added a commit to PeterDaveHello/docker-node that referenced this pull request Dec 21, 2019
@PeterDaveHello
Add missing Alpine 3.9 image for node.js v13, cc nodejs#1135
0dcab14
@PeterDaveHello PeterDaveHello mentioned this pull request Dec 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LaurentGoderre LaurentGoderre LaurentGoderre left review comments
@SimenB SimenB SimenB approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@PeterDaveHello @ljharb @tvainika @nodejs-github-bot @LaurentGoderre @SimenB