Repository navigation
Improve Travis CI deploy/send PR condition - #1136
Merged
Merged
Conversation
LaurentGoderre
approved these changes
Oct 23, 2019
Originally it supports only Dockerfile changes, with this adjustment, it'll now send pull request to the downstream for the version and tag array in generate-stackbrew-library.sh file.
PeterDaveHello
force-pushed
the
update-travis-ci
branch
from
October 23, 2019 18:48
58f3194 to
c728d6a
Compare
Member
Author
|
I think I found a bug before merging, need another review, thanks. |
Member
|
Im wondering if it would be safer to compare the output of stackbrew with upstream instead of changes to the script because changes to the config could result in a different stackbrew without changing the script itself. |
Member
Author
|
Could do that in the future, the enhancement here actually follows the tag / version array in the script only. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally it supports only Dockerfile changes, with this adjustment,
it'll now send pull request to the downstream for the version and tag
array in generate-stackbrew-library.sh file.
cc #1134