Repository navigation
Intl 2021 Updates - #45647
Intl 2021 Updates#45647
Conversation
…snext.intl around)
TypeScript Bot (typescript-bot)
added
Author: Team
For Uncommitted Bug
|
Heya Orta Therox (@orta), I've started to run the parallelized Definitely Typed test suite on this PR at 5f67f65. You can monitor the build here. |
|
I've double checked all the es5 |
|
Long Ho (@longlho) any chance I could get your eyes over this? (and sorry it's taken a while!) |
|
Yup will take a look asap |
Nathan Shively-Sanders (sandersn)
left a comment
Nathan Shively-Sanders (sandersn)
left a comment
There was a problem hiding this comment.
Just a lot of minor edit suggestions.
| hourCycle?: "h11" | "h12" | "h23" | "h24" | undefined; | ||
| } | ||
|
|
||
| interface DateTimeFormatOptions { |
There was a problem hiding this comment.
Probably should merge these two DateTimeFormatOptions declarations
Long Ho (longlho)
left a comment
Long Ho (longlho)
left a comment
There was a problem hiding this comment.
Overall I think es2021 is missing a ton of stuff but I think it's a good enough set of changes in the scaffolding for others to fill in.
Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
|
OK, thanks for the feedback everyone - assuming this is green I will merge weds and start closing all the linked PRs |
|
Editorial suggestions but overall lgtm |
|
Thanks folks |
5 participants
Re: #45646 - no breaking changes in here though
This is quite a few PRs + issues combined, rebased etc:
I've tried to reduce the overall character count for some of the docs (e.g. removing some JSDocs which are redundant because the type system will tell you the types of things) and removed all the specs links, I can't imagine your average
IntlAPI consumer wanting to read the spec (over MDN).Also adds some fresh docs about how lib files work to the README, covering how
Intlis a wee bit special in comparison to some of the other cases we have in the.d.tsfiles.