Skip to content

4.5 Intl changes overview #45646

Closed
Closed

Description

@orta

To make release notes easier further down the line. The PR which brought most of the changes in is #45647

Activity

  1. orta commented on Aug 30, 2021

    @orta
    ContributorAuthor

    #44006 is a breaking change. We previously accidentally had Intl attributes for currencyDisplay and currencySign on a formatter in es5 which meant they would show up in environments where it wasn't necessarily supported as they were added to browsers in 2020. To fix it, update your target to es2020 (or use lib to set up your environment)

  2. orta commented on Aug 30, 2021

    @orta
    ContributorAuthor

    #39662 is a breaking change. To re-use an identifier we brought it back to when it was first introduced in the specs. If someone has a target of es2015 but used es2020.intl in lib and used the type Intl.UnicodeBCP47LocaleIdentifier then it is now available back in es2016.intl.

  3. longlho commented on Sep 4, 2021

    @longlho
    Contributor

    Overall what's the tolerance for breaking changes for this type of fixes? I haven't gone through all the type defs for ecma402 but tbh I suspect there will be quite a few breaking changes since it hasn't been very accurate?

  4. orta commented on Sep 8, 2021

    @orta
    ContributorAuthor

    Kinda tough to give an exact opinion, my somewhat biased view on breakages is roughly "would it break code in the TypeScript website" which doesn't do anything too clever with the Intl APIs and I think generally can be used as an internal metric for what an average web project using the Intl APIs looks like. ( E.g. a quick search show I use mostly APIs for ListFormat/DateTimeFormat/RelativeTimeFormat )

    If it's tightening from string to "a" | "b" those are pretty much always OK for me

  5. Alexsey commented on Nov 6, 2021

    @Alexsey

    I'm sorry, but what is the reason not to include Intl.ListFormat? It's already been on Stage 4 for almost a year and a half yet the latest TS doesn't recognises it :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    DiscussionIssues which may not have code impact

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions