Skip to content

Add Intl.locale types - #39664

Closed
Daniel Gooß (Dangoo) wants to merge 4 commits into
microsoft:mainfrom
Dangoo:feat/37326-add-intl-locale-types
Closed

Daniel Gooß (Dangoo) wants to merge 4 commits into
microsoft:mainfrom
Dangoo:feat/37326-add-intl-locale-types

Conversation

@Dangoo

Copy link
Copy Markdown

Fixes #37326

I'm aware there's currently no entry in the Backlog for it, but a PR makes discussion easier.

Thanks for Vasil Rangelov (@boenrobot) for bringing the issue up and Long Ho (@longlho) for giving feedback on this!

@longlho

Copy link
Copy Markdown
Contributor

Thanks a lot for the changes Daniel Gooß (@Dangoo). 1 last thing I'd say is to rename LDMLHourCycleKey & LDMLCollationCaseFirst since they're not LDML concepts (LDML refers to UTS35 Unicode Locale Data Markup Language) but rather just ECMA402.

@Dangoo
Daniel Gooß (Dangoo) marked this pull request as ready for review July 21, 2020 15:14
@typescript-bot TypeScript Bot (typescript-bot) added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Jul 21, 2020
@hbroer

Copy link
Copy Markdown

Hi, what is the current state for this PR and when will it be merged? Can we do something? Orta Therox (@orta)

@Dangoo

Copy link
Copy Markdown
Author

Hey, are there any blockers stopping you on bringing this in, or is there something we can do to support review/merging? Orta Therox (@orta) Ryan Cavanaugh (@RyanCavanaugh)

@szuend

Copy link
Copy Markdown

Hey, we would like to use this PR in our project until it is merged. Can you confirm that the substance of this PR is available under TypeScript's Apache 2 license?

@JustJenFelice

Copy link
Copy Markdown

What is the status of this PR?

This request for support for Intl spec doesn't seem like it would be controversial, yet the delay in resolving the lack of support is inexplicable. This PR was approved October 2020.

Orta Therox (orta) added a commit to orta/TypeScript that referenced this pull request Aug 30, 2021
Orta Therox (orta) added a commit to orta/TypeScript that referenced this pull request Aug 30, 2021
Orta Therox (orta) pushed a commit that referenced this pull request Sep 8, 2021
* Import of Intl.Locale from #39664

* Handle updating es2020.intl and add es2021 for new DateTimeFormatOptions options - re: #39664

* Extends DateTimeFormatOptions for new Intl APIs - re: #45420

* Handle migrating Intl.NumberFormat.formatToParts to es2018 (keeping esnext.intl around)

* Adds Intl.DisplayNames to es2020 - re: #44022

* Remove attributes added in es2021 from es2020 - re: #42944

* Add a reference to es2021 in the command line parser

* Adds some docs about the lib files

* Baselines

* Allow undefined in Intl inputs to allow for ergonomic usage of exactOptionalPropertyTypes - see #45652

* Adds some tests covering the APIs

* Apply suggestions from code review

Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>

* Handle PR feedback

* More review improvements

Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
@orta

Copy link
Copy Markdown
Contributor

Thanks Daniel Gooß (@Dangoo) - I've taken these changes and integrated them into #45647 which I've just merged into main for 4.5 👍🏻

@typescript-bot

Copy link
Copy Markdown
Contributor

The TypeScript team hasn't accepted the linked issue #37326. If you can get it accepted, this PR will have a better chance of being reviewed.

@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Add Intl.Locale to es2020 lib

8 participants