Repository navigation
Conversation
Without --before, 'meshstack buildingblock wait <uuid>' waits for the run that is going on, such as one that an approval or another command started. Fed with the block's current state, --before waited for a new run and gave up after a minute. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A run that creates building blocks, such as a starterkit, fails as soon as one of them waits for approval, and only the run's logs name that building block. When a run failed, 'meshstack buildingblock wait' and 'trigger-run --wait' now read the building blocks that its logs mention and name those that wait for someone, with the command to review the plan of one that waits for approval. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Coverage of the acceptance run against the meshStack backend, on
Uncovered functions
|
|
2 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Stacked on #85, which changes the same wait code; this PR shows only its own two commits and moves to
mainonce #85 is merged.Two gaps around waiting, one commit each:
meshstack bb wait <uuid>without--beforewaits for the run that is going on now, such as one thatapprove-runor another command started. Before,--beforewas required, and fed with the block's current state it waited for a new run and gave up after a minute. If no run is going on, the command prints the block and its outcome at once.--beforeworks as before.Name the building blocks a failed run waits on. A run that creates building blocks, such as a starterkit, fails as soon as one of them waits for approval: the Terraform provider only warns, and the module's postcondition fails the run. meshStack does not link the created block to the run, only the run's logs name it. So when a run failed,
bb waitandtrigger-run --waitread the building blocks whose uuids appear in the logs (at most 20), and name those that wait for someone, with thebbrun plancommand for one that waits for approval:The lookup is best-effort: a uuid that is no building block, or one the login may not read, is skipped, and so are logs the login may not read.
The
meshstack-cliskill covers both under Waiting for a run.Test plan
task lintgo test ./...: the wait test coversbb waitwithout--beforeon an ended run, and a failed run whose logs name a block that waits for approval.🤖 Generated with Claude Code