Repository navigation
Conversation
'meshstack buildingblockrun plan <run-uuid>' follows the waiting run's predecessor to the detect run, prints its logs as text and names it, so that an agent no longer reads the plan from the logs JSON of the run before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
'meshstack buildingblock approve-run <uuid> --detect-run <run-uuid>' approves the plan of the detect run that 'meshstack buildingblockrun plan' named, without asking. It still approves only that plan: if meshStack has planned the run again since, the approval fails. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
'meshstack buildingblock abort-run <uuid> --run <run-uuid>' aborts that run of the building block without asking, so that a script can reject a stale waiting run without the raw abort request. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
'meshstack buildingblock wait' and 'trigger-run --wait' now name the run that waits for approval and the detect run whose plan it waits on, and point to 'meshstack buildingblockrun plan'. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Coverage of the acceptance run against the meshStack backend, on
Uncovered functions
|
This was referenced Nov 13, 2026
A review of the pull request found these: - 'bb wait' and 'trigger-run --wait' named an empty detect run at APPROVE_RUN, because meshStack sends status.latestDryRunUuid as null while the waiting run is the newest run. They name the action again and point to 'bbrun plan <waiting run>', which finds the detect run. - 'approve-run --detect-run': the 409 message no longer says the plan changed when the caller named the wrong detect run, and it says that the user has to see a new plan. The command prints how to follow the approved run. - 'abort-run --run' no longer reads the building block first, and its tests cover a run in progress, a run that cannot be aborted and a run of another building block. - 'bbrun plan': the error for a run without a predecessor says which run to give, the approve hint asks for the user's go-ahead, and the documented grep skips the step status lines. - The meshstack-cli skill describes how to wait after an approval, asks for the user's go-ahead before an approval or an abort, no longer leaves a stray line behind the abort example, and lists the two commands in its table. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
'approve-run' without a terminal takes the run to approve with --run, together with --detect-run for the plan the caller reviewed, so that both commands name the run they act on the same way. The two flags belong together. - Both commands read the named run, check that it belongs to the building block, and act on it. 'approve-run' refuses a run that does not wait for approval any more, and no longer reads the building block first. - Both commands detect the flag with Flags().Changed, so an all-zero uuid is not taken for a missing flag. - 'bbrun plan', the help texts and the skill show the new command line. - The tests cover the flag pair, a run that does not wait for approval and a run of another building block. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Agents and scripts could not approve or abort a building block run:
approve-runandabort-runonly work on a terminal, so they read the plan from thebbrun logsJSON of the run before and sent the raw approve and abort requests. This PR closes that gap, one commit per step, plus two commits that correct them after a review:meshstack bbrun plan <run-uuid>follows the waiting run'spredecessorto the detect run, prints its logs as text, and prints the detect run's uuid together with theapprove-runcommand to approve it.approve-runreuses the same lookup.approve-run <uuid> --run <run-uuid> --detect-run <detect-run-uuid>approves without asking.--runnames the run to approve, asabort-run --rundoes, and--detect-runthe plan the caller reviewed; the two go together. The approval is bound to that plan: if meshStack has planned the run again since, or the uuid is not the run's detect run, meshStack answers 409. The command then says that the user has to see the new plan and allow it again.abort-run <uuid> --run <run-uuid>aborts that run without asking, whether it waits for approval or is in progress, and also if it is not the latest run. It names the run instead of taking a--yes, and refuses a run of another building block.bb waitandtrigger-run --waitname the action, the waiting run andbbrun planwhen they stop atAPPROVE_RUN. They do not name the detect run:status.latestDryRunUuidis null while the run waits, andbbrun planfinds the detect run itself.Without a terminal and without the new flags, both commands still refuse, and now point to their
--help. Themeshstack-cliskill describes the new flow under Approval gates and preflight runs.Known limits
abort-run --runaborts the run in whatever state it is in, and does not ask. If someone approves a waiting run after the caller read it, the apply in progress stops. The skill tells agents to read the building block again right before.bbrun planprints the detect run's uuid in a log line on stderr, and has no-oflag.🤖 Generated with Claude Code