Repository navigation
Conversation
|
Coverage of the acceptance run against the meshStack backend, on
Uncovered functions
|
grubmeshi
force-pushed
the
feature/single-go-bin-runner
branch
from
October 13, 2026 13:52
f7111e1 to
73db1b9
Compare
grubmeshi
force-pushed
the
feature/single-go-bin-runner
branch
from
October 13, 2026 13:58
73db1b9 to
ebf91ce
Compare
grubmeshi
force-pushed
the
feature/single-go-bin-runner
branch
2 times, most recently
from
October 15, 2026 19:18
9ab69a7 to
322b873
Compare
grubmeshi
force-pushed
the
feature/single-go-bin-runner
branch
10 times, most recently
from
October 23, 2026 11:53
3a034bf to
eb512e3
Compare
grubmeshi
force-pushed
the
feature/single-go-bin-runner
branch
2 times, most recently
from
October 28, 2026 11:58
5975d78 to
98854c7
Compare
grubmeshi
force-pushed
the
feature/single-go-bin-runner
branch
3 times, most recently
from
October 29, 2026 04:56
abbd309 to
e90226d
Compare
grubmeshi
force-pushed
the
feature/single-go-bin-runner
branch
2 times, most recently
from
October 30, 2026 09:04
c85b993 to
0332c2c
Compare
grubmeshi
force-pushed
the
feature/single-go-bin-runner
branch
from
November 2, 2026 11:36
2ac56de to
3926fcc
Compare
grubmeshi
force-pushed
the
feature/single-go-bin-runner
branch
from
November 11, 2026 23:13
3926fcc to
8e92887
Compare
grubmeshi
force-pushed
the
feature/single-go-bin-runner
branch
from
November 12, 2026 00:14
8e92887 to
9807a76
Compare
grubmeshi
force-pushed
the
feature/single-go-bin-runner
branch
2 times, most recently
from
November 12, 2026 02:53
2d49f9d to
9f1ecad
Compare
grubmeshi
marked this pull request as ready for review
November 12, 2026 03:41
grubmeshi
force-pushed
the
feature/single-go-bin-runner
branch
6 times, most recently
from
November 13, 2026 08:18
3032cd0 to
f74c926
Compare
…un without a stored one A command takes the profile that --profile or MESHSTACK_PROFILE names, and an unknown name is an error. Without a name it takes the current profile when no endpoint is given or the profile has that endpoint, else the only stored profile with that endpoint. With no such profile it runs with the endpoint and the credential from the settings alone: it stores nothing and caches no token. Only 'meshstack login' creates a profile. An endpoint is a scheme and a host, and one with a path is refused. 'meshstack api <URL>' takes the origin of the URL as the endpoint. A profile stores an API token with its other credentials. A token that an earlier version cached is gone, so log in with --apitoken again. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
…ion to client/types/version Another module can then name the HTTP client, its request options and the version type that client/ already uses in its exported API. The files move unchanged, apart from import paths. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
grubmeshi
force-pushed
the
feature/single-go-bin-runner
branch
from
November 19, 2026 08:21
f74c926 to
d537434
Compare
…Client and hal.Links Every kind's client is client.MeshObjectClient[M, Filter] with Read, List, Create, Update and Delete under a type alias, and List reads a page only when the caller asks for an object of it. An action of an object follows a link of its _links through hal.Links: Get, Post and Delete send the media type of the kind, decode the answer and let its links follow themselves too. A link to another origin than the endpoint is refused. client.Raw and the per-kind methods such as ReadFunc, TriggerRun and GetLogs are gone. client/http has one DoRequest, which returns the response body, and UnmarshalJsonBody, ReadAllBody and IgnoreResponse consume it. Request options set the retry policy, refuse redirects and capture the response header. A GET and a DELETE are retried on every transient failure, any other method on 423, 429 and 503. The debug log shows the first 1024 bytes of a body as they came. internal/json is the only importer of encoding/json/v2. The polymorph package reads and writes a struct by its type property, as the implementation of a definition version needs. The API docs are cached by the ETag of /api/openapi. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
MeshBuildingBlockRunnerImplementationTypes is an enum.Enum like the other enums of the client, and MeshBuildingBlockRunnerSpec.ImplementationType is an entry of it. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
…hrough the run client A building block runner works with client.Client.BuildingBlockRun: Claim hands it the next run with the run token, the inputs and the implementation, and sends the version of the HTTP client's user agent as X-Meshcloud-Runner-Version. RegisterSource, UpdateSourceSteps, DownloadArtifact and UploadArtifact address a run by its uuid, because the API key of a runner may not read a run. The names follow the operations of the meshObject API. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
http.Error.IsTemporary is true for 408, 423, 429 and every 5xx, so that a caller that polls, as a runner does for a pipeline run, knows when to go on. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Go 1.27.0 has GO-2026-6859 in net/http, which fails the vulnerability check. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
A refused connection is retried under every policy and for every method, because the server received nothing. A runner started together with meshStack then waits for its API, and a client outlasts a restart of meshStack. Each retry logs a warning, so a person who gave a wrong endpoint sees why the command waits and can stop it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
… JSON pointer A debug log shows a JSON body indented, with the value at each redacted JSON pointer replaced by "[REDACTED]", and applies one-token pointers to the fields of a url-encoded form. Every request redacts the plaintext of a secret and the clientSecret of an API key; http.WithRedactedJsonPointers adds the tokens of an OIDC grant, the access token of an API key login and the run token of a claimed run. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…client/http http.Error now shows the body as it came, and BodyAsJson reads it into the type the caller expects. client.MeshObjectError reads the error body of meshStack and keeps what wraps the http.Error, such as the authorization of a 403. internal/oidc reads its OAuth error itself. meshstack api no longer writes the body of a failed answer to stdout; the error says what meshStack answered. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
grubmeshi
force-pushed
the
feature/single-go-bin-runner
branch
from
November 19, 2026 15:29
d537434 to
75703bd
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



The building block runner (meshcloud/building-block-runner#86) and the Terraform provider (meshcloud/terraform-provider-meshstack#392) use the CLI as a Go module. This PR gives them one generic client for every meshObject kind, a run client for runners, and a profile resolution that works without a stored profile. It removes more lines than it adds (about +5,050/-6,440).
Commits
--profile,MESHSTACK_PROFILE), else the current profile when it has the endpoint in use, else the only stored profile with that endpoint. An unknown name is an error, also formeshstack logout -p. Without a matching profile, the CLI runs with the endpoint and credential from the settings and stores nothing. Onlymeshstack logincreates a profile. An endpoint is a scheme, a host and an optional port; one with a path, query or user info is refused. With a full URL,meshstack apiandmeshstack api-docstake its scheme and host as the endpoint. A token that an earlier version cached is gone, so users log in with--apitokenagain, and that token is sent until it really expires.internal/httpmoves toclient/http. This commit only renames, so that other modules can use the HTTP client and its options.client.MeshObjectClient[M, Filter]with string ids, whoseListreturns an iterator. Actions of an object follow the links of its_linksthroughhal.Links, and the commands that trigger, approve, reject or abort a run or read its logs use these links too. The per-kind wrappers andclient.Raware gone. A GET or DELETE is retried on every transient failure, any other method on 423, 429 and 503, someshstack api -X DELETEretries a 502 and 504 like a GET. A 423 on the Terraform state goes straight to tofu, which names the lock holder and waits itself.meshstack api-docsreads the API docs the endpoint serves at/api/openapi, without a login, and keeps them until the ETag changes; the published docs are the fallback.Claim,RegisterSource,UpdateSourceSteps,DownloadArtifactandUploadArtifact. All butClaimaddress a run by its uuid, because the API key of a runner cannot read a run.http.Error.IsTemporary()is true for 408, 423, 429 and every 5xx, so that a caller that polls knows when to go on.net/http.--debuglogs. Secrets in request and response bodies are redacted by JSON pointer:plaintextandclientSecretanywhere, the OIDC tokens and codes, the access token of an API key login and the run token of a claim. A caller adds pointers withhttp.WithRedactedJsonPointers. TheAuthorizationheader stays redacted.http.Errorshows the body as it came and reads it withBodyAsJson[T]();client.MeshObjectErrorOfturns it into aclient.MeshObjectErrorand keeps what wraps it.meshstack apiprints nothing on stdout for an answer outside 2xx; the error shows what meshStack answered, or the body as it came where it is no error of meshStack.Review focus
The largest parts are the profile resolution (
internal/profile/resolve.go) and the generic client (client/meshobject.go,client/types/hal). Commit 2 only renames.Cross-repo PRs and merge order
#86 and #392 pin the current head of this PR in
go.mod, so each push here needs a new pin in both.go.modpin from this head to that release.meshstack-cli Pincheck stays red until this PR is merged.🤖 Generated with Claude Code