Skip to content

Existing comment's links should be automatically updated by the bot #24

Closed

Description

@saki7

Currently, cpp-warning-notifier does nothing when the recent warning status exactly matches the previous build. This was a design decision I proposed and is still the preferred behavior. However, I still want the links to be updated unconditionally for several reasons:

  • People who don't know the above behavior will get confused by the stale links
  • I sometimes want to click the links to use them as a "quick jump" button

I think there's an API for the bots to update their own comments.

Activity

  1. yaito3014 commented on Oct 15, 2026

    @yaito3014
    Member

    For clarification, does "when the recent warning status exactly matches the previous build" mean "even if both builds have warnings, they differ when warning bodies differ"? It changes the warning detection logic, because it have to parse warning bodies for that.
    I DO think just "both have warnings, so update links" have less sense, but parsing and comparing the warning bodies is bit complex.

    P.S.
    I implemented the logic, according to my assumption. Please check PR #28

  2. yaito3014 commented on Oct 15, 2026

    @yaito3014
    Member

    Discussed on private; agreed that we should keep single live comment and always overwrite it.

    #28 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions