Repository navigation
Conversation
No behavior change. The create/replace/skip choice now lives in action/src/comment.ts so it can be unit-tested with node --test.
When neither the new build nor the previous bot comment has a warning, the bot used to stay silent, leaving the old comment pointing at a stale run. It now edits that comment in place with the fresh table, so the links always jump to the latest run while still not notifying anyone. Fixes #24
An object literal with only an id has no property in common with CommentLike, so tsc rejected it (TS2559). Neither the Rollup build nor node --test type-checks the test file, which is why it went unnoticed.
The check used to search the entire comment HTML for "warning", which every link URL matches when the repository name contains that word (as iris-cpp/cpp-warning-notifier does), so the bot always posted a new comment. The status strings are now shared with the renderer and only the link text inside status cells is compared against the warning one.
Recognises the GCC/Clang and MSVC line formats, strips the Actions timestamp and the runner workspace prefix, and falls back to a file-less diagnostic for any other line the previous line-based detection would have counted. Not wired in yet.
A cell's warnings are identified by the multiset of (file, flag, message); line and column are ignored so that unrelated edits above a warning do not count as a change. The digest of that multiset, with the cell's environment and status, is embedded in the comment as a machine-readable HTML comment block so the next run can compare without re-reading expired logs. Not wired in yet.
The script now parses all diagnostics of a job instead of grepping for the first one, keeps them on the cell, and renders the comment through a tested module: the table as before, a collapsed list of warnings per environment, and the machine-readable block. Status and link anchor are derived from the same diagnostics, so they are unchanged. The decision still looks only at statuses; the next commit uses the block.
When the previous bot comment carries a block, the per-cell statuses and warning digests are compared with the current build. Identical means the comment is edited in place (links refreshed), even when warnings exist. Any difference involving a warning on either side minimizes the old comment and posts a new one. A previous comment without a block falls back to its status cells once. Refs #24
This comment has been minimized.
This comment has been minimized.
One <details> whose summary gives the total count and the number of environments, with the warnings grouped per environment as nested lists inside, instead of one collapsed section per environment.
This comment has been minimized.
This comment has been minimized.
This reverts commit 5a5f725.
48 warnings in 12 environments
|
||||||||||||||||||||||||||||||
yaito3014
marked this pull request as ready for review
October 15, 2026 03:17
Member
Author
|
Discussed on private; agreed that we should keep single live comment and always overwrite it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #24