Skip to content

Change behavior to keep single live comment - #29

Merged
yaito3014 merged 5 commits into
mainfrom
single-comment
Oct 15, 2026
Merged

yaito3014 merged 5 commits into
mainfrom
single-comment

Conversation

@yaito3014

Copy link
Copy Markdown
Member

fixes #24

Tests run with node --test directly on the TypeScript sources, which
Node 24 strips types from. rewriteRelativeImportExtensions lets both
the test runner and the Rollup build import modules by their .ts path
under the inherited node16 module resolution.
Agreed with the issue author in #24: the bot never posts a second
comment while one exists. Every run overwrites the latest bot comment,
so its links always point at the latest run without notifying anyone.
When the new result has warnings and the comment had been minimized,
it is un-minimized so that the warnings are visible again. The
decision is a small tested function.

Closes #24
@cppwarningnotifier

cppwarningnotifier Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
EnvironmentC++20C++23C++26
ubuntu24.04GNU13Debug⚠️warning⚠️warning⚠️warning
Release⚠️warning⚠️warning⚠️warning
LLVM20Debug⚠️warning⚠️warning⚠️warning
Release⚠️warning⚠️warning⚠️warning

Updated at 2026-10-15 06:24:04 UTC for commit d92d6c8

Since the bot now keeps editing a single comment, readers need to see
which build it reflects. The trailer gives the update time in UTC and
links the pull request's head commit; GITHUB_SHA is the temporary merge
commit on pull_request events, so the head SHA is read from the event
payload.
@yaito3014
yaito3014 merged commit 8f3152a into main Oct 15, 2026
13 checks passed
@yaito3014
yaito3014 deleted the single-comment branch October 15, 2026 06:27
@saki7

saki7 commented Oct 15, 2026

Copy link
Copy Markdown
Member

𝙎𝙪𝙥𝙚𝙧 𝙏𝙝𝙖𝙣𝙠𝙨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Existing comment's links should be automatically updated by the bot

2 participants