Skip to content

BigTable: Fixing client for system tests - #5398

Merged
tseaver merged 3 commits into
googleapis:masterfrom
zakons:feature/fixing_client_for_system_tests
May 31, 2018
Merged

BigTable: Fixing client for system tests#5398
tseaver merged 3 commits into
googleapis:masterfrom
zakons:feature/fixing_client_for_system_tests

Conversation

@aneepct

@aneepct aneepct commented May 29, 2018

Copy link
Copy Markdown
Contributor

Change the use of property instead of private variables for admin and data clients. System tests are also working fine with this changes.

@aneepct
aneepct requested a review from lukesneeringer as a code owner May 29, 2018 10:25
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 29, 2018
@aneepct

aneepct commented May 29, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@sduskis Need changes where private variables were used instead of property for admin and data clients. Please review I need this PR to merge in order to create new system tests on other PR #5315, #5370 and #5360

@tseaver tseaver added the api: bigtable Issues related to the Bigtable API. label May 29, 2018
@tseaver

tseaver commented May 29, 2018

Copy link
Copy Markdown
Contributor

I'm not sure I understand the rationale here: the table_admin_client and instance_admin_client properties already exist, which means that external code (e.g., the system tests) can use them. Why is this issue a blocker for anything else, if it only changes method implementations to use the properties?

@aneepct

aneepct commented May 30, 2018

Copy link
Copy Markdown
Contributor Author

@tseaver I created separate PR for these changes because I have to make similar changes on all 3 PR's #5315, #5370 and #5360. I will update them once this changes will be merged.

@tseaver
tseaver merged commit 5a79d5d into googleapis:master May 31, 2018
tseaver added a commit that referenced this pull request May 31, 2018
@tseaver
Unmark most of the xfailed tests.
1c730f4 
Fixed by PR #5398.
This was referenced May 31, 2018
Merged
Closed
tseaver added a commit that referenced this pull request May 31, 2018
@tseaver
Unmark most of the xfailed tests.
0366a2d 
Fixed by PR #5398.
parthea pushed a commit that referenced this pull request Nov 22, 2025
@aneepct @tseaver
BigTable: use client properties rather than private attrs (#5398)
12ff12d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer

Assignees

No one assigned

Labels

api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aneepct @tseaver @googlebot