BigTable: Add truncate table and drop by prefix on top of GAPIC integration by aneepct · Pull Request #5360 · googleapis/google-cloud-python

aneepct · 2018-05-22T11:42:55Z

Add methods on Table to delete rows by prefix and truncate all rows.

truncate
drop_by_prefix

Sign in to view

            self.name)
        return response_iterator

+    def truncate(self, timeout=60):


Sign in to view

+                                          delete_all_data_from_table=True,
+                                          timeout=timeout)
+
+    def drop_by_prefix(self, row_key_prefix, timeout=60):


…into feature/add_truncate_table_and_drop_by_prefix

aneepct · 2018-05-29T10:15:07Z

@sduskis Fixed please review

Sign in to view

+
+        result = table.truncate()
+
+        self.assertEqual(result, expected_result)


Sign in to view

+
+        self.assertEqual(result, expected_result)
+
+    def test_drop_by_prefix_w_timestamp(self):


Sign in to view

+
+        data_api = bigtable_client.BigtableClient(mock.Mock())
+        table_api = bigtable_table_admin_client.BigtableTableAdminClient(
+            mock.Mock())


Sign in to view

+
+        data_api = bigtable_client.BigtableClient(mock.Mock())
+        table_api = bigtable_table_admin_client.BigtableTableAdminClient(
+            mock.Mock())


Sign in to view

+
+        data_api = bigtable_client.BigtableClient(mock.Mock())
+        table_api = bigtable_table_admin_client.BigtableTableAdminClient(
+            mock.Mock())


…into feature/add_truncate_table_and_drop_by_prefix

Sign in to view

        Config.CLIENT = Client(admin=True, credentials=credentials)
    else:
-        Config.CLIENT = Client(admin=True)
+        Config.CLIENT = Client(project='grass-clump-479', admin=True)


sduskis

I'm good to go when @tseaver is

Sign in to view

+        row_keys = [
+            'row_key_1', 'row_key_2', 'row_key_3', 'row_key_4', 'row_key_5',
+            'row_key_pr_1', 'row_key_pr_2', 'row_key_pr_3', 'row_key_pr_4',
+            'row_key_pr_5']


Sign in to view

+        row_keys = [
+            'row_key_1', 'row_key_2', 'row_key_3', 'row_key_4', 'row_key_5',
+            'row_key_pr_1', 'row_key_pr_2', 'row_key_pr_3', 'row_key_pr_4',
+            'row_key_pr_5']


zakons · 2018-06-11T04:19:41Z

@tseaver Ready to merge? Thanks.

tseaver · 2018-06-12T15:37:11Z

@aneepct One of the system tests added by this PR is failing on CI this morning 1 2 3 4:

____________________ TestDataAPI.test_drop_by_prefix_table _____________________

self = &lt;tests.system.TestDataAPI testMethod=test_drop_by_prefix_table&gt;

    def test_drop_by_prefix_table(self):
        row_keys = [
            b'row_key_1', b'row_key_2', b'row_key_3', b'row_key_4',
            b'row_key_5', b'row_key_pr_1', b'row_key_pr_2', b'row_key_pr_3',
            b'row_key_pr_4', b'row_key_pr_5']
    
        for row_key in row_keys:
            row = self._table.row(row_key)
            row.set_cell(COLUMN_FAMILY_ID1, COL_NAME1, CELL_VAL1)
            row.commit()
            self.rows_to_delete.append(row)
    
        self._table.drop_by_prefix(row_key_prefix='row_key_pr', timeout=200)
    
        read_rows = self._table.yield_rows()
        expected_rows_count = 5
        read_rows_count = 0
    
        for row in read_rows:
            if row.row_key.decode('utf-8') in row_keys:
                read_rows_count += 1
    
&gt;       self.assertEqual(expected_rows_count, read_rows_count)
E       AssertionError: 5 != 0

Added in PR #5360.

…ration (#5360)

Added in PR #5360.

Add truncate and drop by prefix

1f824c5

aneepct requested a review from lukesneeringer as a code owner May 22, 2018 11:42

googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 22, 2018

aneepct mentioned this pull request May 22, 2018

BigTable: Add data app profile id #5275

Closed

sduskis suggested changes May 22, 2018

View reviewed changes

tseaver added the api: bigtable Issues related to the Bigtable API. label May 22, 2018

aneepct added 4 commits May 23, 2018 11:27

Add default timeout value

b7efabb

Update timestamp logic

4da1be6

Added unit test for timestamp logic

02dc657

Merge branch 'master' of https://github.com/zakons/google-cloud-python …

4dfde6c

…into feature/add_truncate_table_and_drop_by_prefix

aneepct mentioned this pull request May 29, 2018

BigTable: Fixing client for system tests #5398

Merged

sduskis reviewed May 30, 2018

View reviewed changes

Comment thread bigtable/tests/unit/test_table.py

result = table.truncate()

self.assertEqual(result, expected_result)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

tseaver reviewed May 30, 2018

View reviewed changes

Comment thread bigtable/tests/unit/test_table.py Outdated

self.assertEqual(result, expected_result)

def test_drop_by_prefix_w_timestamp(self):

This comment was marked as spam.

Sign in to view

Done required changes

2c6d8a7

tseaver suggested changes May 31, 2018

View reviewed changes

aneepct added 3 commits June 1, 2018 08:08

Fix required changes on unit test cases

c63b0e6

Merge branch 'master' of https://github.com/zakons/google-cloud-python …

444db17

…into feature/add_truncate_table_and_drop_by_prefix

Create system tests and update truncate and drop by prefix code

6609be2

sduskis reviewed Jun 4, 2018

View reviewed changes

Remove static project defined

bcbfc75

sduskis approved these changes Jun 7, 2018

View reviewed changes

tseaver suggested changes Jun 7, 2018

View reviewed changes

aneepct added 2 commits June 8, 2018 17:11

Fix requried changes

1516395

Remove static project id

bb7d47e

tseaver approved these changes Jun 8, 2018

View reviewed changes

tseaver merged commit 5f39feb into googleapis:master Jun 11, 2018

tseaver added a commit that referenced this pull request Jun 12, 2018

Fix Py3 breakage in new system test.

63c61f4

Added in PR #5360.

tseaver mentioned this pull request Jun 12, 2018

Fix Py3 breakage in new system test. #5474

Merged

tseaver added a commit that referenced this pull request Jun 12, 2018

Fix Py3 breakage in new system test. (#5474)

7a0a97f

Added in PR #5360.

tseaver mentioned this pull request Jun 12, 2018

Fix Failing BigTable System tests #5362

Closed

tseaver mentioned this pull request Sep 15, 2021

tests: refactor systests into separate modules w/ pytest fixtures googleapis/python-bigtable#393

Merged

parthea pushed a commit that referenced this pull request Nov 22, 2025

BigTable: Add truncate table and drop by prefix on top of GAPIC integ…

a6617f8

…ration (#5360)

parthea pushed a commit that referenced this pull request Nov 22, 2025

Fix Py3 breakage in new system test. (#5474)

54207a2

Added in PR #5360.


		result = table.truncate()

		self.assertEqual(result, expected_result)


		self.assertEqual(result, expected_result)

		def test_drop_by_prefix_w_timestamp(self):

Conversation

aneepct commented May 22, 2018

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

aneepct commented May 29, 2018

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

sduskis left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

zakons commented Jun 11, 2018

Uh oh!

tseaver commented Jun 12, 2018

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants