Skip to content

BigTable: Add admin app profile methods on Instance - #5315

Merged
tseaver merged 11 commits into
googleapis:masterfrom
zakons:feature/add_admin_app_profile_methods_to_instance
May 31, 2018
Merged

BigTable: Add admin app profile methods on Instance#5315
tseaver merged 11 commits into
googleapis:masterfrom
zakons:feature/add_admin_app_profile_methods_to_instance

Conversation

@aneepct

@aneepct aneepct commented May 9, 2018

Copy link
Copy Markdown
Contributor

Add methods to the Instance class to manage app profiles:

  1. create_app_profile
  2. get_app_profile
  3. list_app_profiles
  4. update_app_profile
  5. delete_app_profile

@aneepct
aneepct requested a review from lukesneeringer as a code owner May 9, 2018 09:56
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 9, 2018
@aneepct aneepct mentioned this pull request May 9, 2018
Closed
@zakons zakons mentioned this pull request May 10, 2018
Merged
@tseaver tseaver added the api: bigtable Issues related to the Bigtable API. label May 10, 2018
sduskis
sduskis suggested changes May 18, 2018
View reviewed changes

@sduskis sduskis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aneepct, can you please add a system test? Please test the create and update paths with both "single cluster" and "all clusters" variants.

Comment thread bigtable/google/cloud/bigtable/instance.py Outdated
:type: app_profile_id: str
:param app_profile_id: The unique name for the new app profile.

:type: etag: str

This comment was marked as spam.

Sign in to view

Comment thread bigtable/google/cloud/bigtable/instance.py Outdated
creating the app profile.

:type: metadata: [Sequence[Tuple[str, str]]]
:param: metadata: (Optional) Additional metadata that is provided to

This comment was marked as spam.

Sign in to view

sduskis
sduskis suggested changes May 18, 2018
View reviewed changes
Comment thread bigtable/google/cloud/bigtable/instance.py Outdated
:param: metadata: (Optional) Additional metadata that is provided to
the method.

:type: routing_policy_type: int

This comment was marked as spam.

Sign in to view

Comment thread bigtable/google/cloud/bigtable/instance.py Outdated

def update_app_profile(self, app_profile_id, update_mask, etag='',
description='', ignore_warnings=None, metadata=None,
routing_policy_type=ROUTING_POLICY_TYPE_ANY,

This comment was marked as spam.

Sign in to view

Comment thread bigtable/google/cloud/bigtable/instance.py Outdated
:param: ignore_warnings: (Optional) If true, ignore safety checks when
creating the app profile.

:type: metadata: [Sequence[Tuple[str, str]]]

This comment was marked as spam.

Sign in to view

sduskis
sduskis suggested changes May 22, 2018
View reviewed changes

@sduskis sduskis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I have concerns about the way the create / update protobuf objects are created. Can you please add unit tests to make sure that the protobuf requests objects are what you would expect, and also add system tests to make sure that the end-to-end functionality works as expected?

Comment thread bigtable/google/cloud/bigtable/instance.py Outdated
:param: routing_policy_type: There are two routing policies
ROUTING_POLICY_TYPE_ANY = 1 and
ROUTING_POLICY_TYPE_SINGLE = 2.
By default it is ROUTING_POLICY_TYPE_ANY

This comment was marked as spam.

Sign in to view

Comment thread bigtable/google/cloud/bigtable/instance.py Outdated
:param: routing_policy_type: There are two routing policies
ROUTING_POLICY_TYPE_ANY = 1 and
ROUTING_POLICY_TYPE_SINGLE = 2.
By default it is ROUTING_POLICY_TYPE_ANY

This comment was marked as spam.

Sign in to view

Comment thread bigtable/google/cloud/bigtable/instance.py

app_profile = instance_pb2.AppProfile(
name=name, description=description,
multi_cluster_routing_use_any=multi_cluster_routing_use_any,

This comment was marked as spam.

Sign in to view

Comment thread bigtable/tests/unit/test_instance.py Outdated
# Perform the method and check the result.
app_profile_id = 'appProfileId1262094415'
result = instance.create_app_profile(app_profile_id=app_profile_id,
routing_policy_type=1)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread bigtable/tests/unit/test_instance.py Outdated

# Perform the method and check the result.
app_profile_id = 'appProfileId1262094415'
result = instance.create_app_profile(app_profile_id=app_profile_id,

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@aneepct aneepct mentioned this pull request May 29, 2018
Merged
@tseaver
tseaver merged commit 4f586b6 into googleapis:master May 31, 2018
parthea pushed a commit that referenced this pull request Nov 22, 2025
@aneepct @tseaver
BigTable: Add admin app profile methods on Instance (#5315)
eb9eb19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer
1 more reviewer
@sduskis sduskis sduskis approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aneepct @sduskis @tseaver @googlebot