Repository navigation
feat(mcp): promote meeting_lookup to a first-class plugin tool - #31
Merged
Merged
Conversation
The bundled meeting skills and the using-glean reference tell the model to call meeting_lookup, but the plugin only exposed it indirectly through calendar skills' tool files and run_tool. Add it to REMOTE_TOOLS_ALLOWLIST so it is listed and dispatched like search and employee_search when the Glean backend forwards it.
This was referenced Oct 12, 2026
shashank-tomar-glean
marked this pull request as ready for review
October 12, 2026 17:27
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
meeting_lookuptoREMOTE_TOOLS_ALLOWLIST, so the plugin lists and dispatches it as a first-class tool, the same way it handlessearchandemployee_search.Today the plugin's own content assumes this tool exists. The
using-gleanreference, themeeting-analyzeragent, and themeeting-prepandcatch-upskills all tell the model to callmeeting_lookup. But the plugin drops it from the remote tool list, so the only way to reach it is indirectly, through a calendar skill's tool file andrun_tool. In practice, "what's on my calendar today?" or "what was decided in yesterday's standup?" lands on a Google Calendar connector skill or onsearchinstead.Changes
shared/glean/mcp/src/tools/remote-passthrough.ts: addmeeting_lookuptoREMOTE_TOOLS_ALLOWLIST.shared/glean/mcp/tests/remote-passthrough.test.ts: update the pinned allowlist.Promoted tools stay behind the existing
toolPromotionpolicy feature, so no policy change is needed.Rollout
The plugin only promotes tools that the Glean backend forwards through its plugin gateway. Matching backend changes add
meeting_lookupto that forwarded set and serve it on every deployment's default MCP server. Until they ship, this change is a no-op because the filter never sees the tool, so it can merge in any order.Testing
npm run typecheck:bundle,npm run test:bundle(432 tests), andnpm test(build plus validate for claude, cursor, and codex) all pass.meeting_lookup(current production), the tool list is unchanged, as expected.meeting_lookup. Codex called it directly for "What's on my calendar today?", "What meetings do I have for the rest of this week?", a meeting-summary question (followed byread_documenton the transcript), and "Prep me for my next meeting". Every call completed.meeting_lookup, the plugin lists it as well.