Repository navigation
chore: require PACT review through CODEOWNERS - #39
Merged
Merged
Conversation
Make Steve Calvert and David Hamilton code owners for every path. The main branch ruleset requires code owner review, so a PR cannot merge until one of them approves.
Name @gleanwork/pact instead of two individuals, so team membership controls who can approve and one person being away does not block merges.
david-hamilton-glean
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PRs have been merging into this repo without review. #26, #31 and #32 merged with no approval, because main had no branch protection and no CODEOWNERS file.
This PR makes the @gleanwork/pact team the code owner for every path. Team membership now controls who can approve. The team has write access to this repo, which GitHub requires before it honors a team in CODEOWNERS.
A new ruleset on main, "main: require PACT review", now enforces it:
Until this file is on main, the ruleset still requires one approval, from any reviewer.
Test plan