Skip to content

fix(glean): align meeting_lookup guidance with inclusive date bounds - #30

Closed
shashank-tomar-glean wants to merge 2 commits into
mainfrom
shashank/meeting-lookup-inclusive-dates
Closed

shashank-tomar-glean wants to merge 2 commits into
mainfrom
shashank/meeting-lookup-inclusive-dates

Conversation

@shashank-tomar-glean

@shashank-tomar-glean shashank-tomar-glean commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Summary

The meeting_lookup tool that Glean MCP serves today treats after and before as inclusive and requires both on every call. Its schema no longer lists extract_transcript or exhaustive.

The plugin's bundled guidance still described the old behavior. It told the model that filtering is exclusive and to pad each bound by a day, and its examples passed parameters the schema no longer lists. As a result, "what's on my calendar today?" or a single-date question pulls in meetings from the neighboring days.

Changes

  • using-glean/reference/meeting-lookup.md: rewrite the parameter table, date handling, examples, and pitfalls to match the current schema:
    • after / before are required and inclusive.
    • The week and month keywords are listed.
    • peer must be an email.
    • Outlook calendar_ids must come from the user.
    • cursor handles paging when a response returns one; if a response reports truncation without a cursor, narrow the date range.
    • Transcripts are read with read_document, using the meeting's transcript URL or its url.
    • Response fields are described generically rather than by exact name, so the guidance holds for both the current MCP response shape and the upcoming cursor-based one.
  • using-glean/reference/search.md: fix the meeting_lookup row of the cross-tool filter table, whose example padded the dates.
  • agents/meeting-analyzer.md: replace the inline query-string style and extract_transcript with structured parameters.

Testing

  • npm test passes: build plus validate for claude, cursor, and codex.
  • Checked against the live Glean MCP meeting_lookup tool schema. after="today", before="today" returns all of today's meetings and nothing from adjacent days.
  • End to end with Codex CLI 0.160.1, using a local build of this branch combined with #31 and #32, against an experimental Glean backend that forwards meeting_lookup to the plugin. Codex read using-glean/reference/meeting-lookup.md before its calendar calls.
    • "What's on my calendar today?": one meeting_lookup call with after="today" and before="today", returning exactly that day's events.
    • "What meetings do I have for the rest of this week?": after="now" and before="this_week", covering Monday to Friday with no padded days.
    • "Summarize my most recent meeting with the QA team": meeting_lookup, then read_document on the transcript URL from the result. Today's MCP response names that field meetingTranscriptUrl, and the field-agnostic wording handled it.

Not in this PR: a few skills (meeting-prep, catch-up, onboarding, project-awareness, project-handoff, project-synthesizer) still use the meeting_lookup "[topic] [time period]" shorthand. That can be a follow-up. In the same end-to-end runs, "Prep me for my next meeting" went through meeting-prep and failed in one of four runs: the model reported that calendar tools were unavailable.

The meeting_lookup tool served by Glean MCP treats after/before as
inclusive and requires both, and no longer accepts extract_transcript or
exhaustive. The bundled reference still told the model to pad each bound
by a day and to pass those parameters, so "today" or single-date queries
pulled in meetings from the neighboring days.

Update the using-glean meeting_lookup reference, the meeting_lookup row
in the search.md cross-tool table, and the meeting-analyzer agent to the
current schema: required inclusive bounds, period keywords, peer by
email, cursor paging, and reading transcripts with read_document.
@shashank-tomar-glean shashank-tomar-glean self-assigned this Oct 12, 2026
@shashank-tomar-glean
shashank-tomar-glean marked this pull request as ready for review October 12, 2026 10:08
…d names

Refer to the transcript URL and attendee/organizer emails generically, and cover responses that report truncation without a cursor, so the guidance holds for both the current MCP response shape and the upcoming cursor-based one.
@steve-calvert-glean

Copy link
Copy Markdown
Contributor

Thanks for this. You're right that the bundled guidance is wrong. It says the date bounds are exclusive and tells the model to pad them, so a single-date question pulls in meetings from the neighboring days.

We're closing this in favor of a different fix. We're cutting using-glean/reference/*.md down to when to use each tool, and the Glean server's tool descriptions become the one place that describes parameters. That removes the wrong guidance, and it keeps the docs from drifting from the schema again.

The parameter details here belong in the meeting_lookup description on the server: after and before are required and inclusive, peer is an email, calendar_ids come from the user, and cursor handles paging. I'll link the cleanup PR here when it's up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants