Skip to content

Phase 4: Ship /squad review in gh aw add and update the gh-aw guide #1736

Closed

Description

@bradygaster

Parent: #1729
Depends on: #1733

Goal

Make /squad review installable and documented. Until this lands, the workflow exists only in this repository and the published guide describes a review gap that no longer matches reality.

Acceptance criteria

  • squad-review.md added to gh aw add install ordering and to the workflow templates shipped by the CLI
  • docs/src/content/docs/guide/gh-aw.md: replace the "Review lifecycle and current gaps" section with the actual behavior, including provenance detection, verdict semantics, and the fact that human approval remains mandatory
  • Add /squad review (and /squad review fix, if Deferred follow-up: Human-initiated review remediation worker #1735 ships) to the single consolidated command table in that guide
  • Document the fast-path implication: skipping review is possible while it is advisory, and what that costs
  • Docs validated per the repo's docs structure checks

Notes

The guide currently states plainly that there is no /squad review command and names the resulting gap. That text was accurate when written and becomes wrong the moment Phase 1 merges, so this issue should land in the same release as #1733 even though it is listed last.

Activity

  1. added
    squadSquad triage inbox — Lead will assign to a member
    on Aug 17, 2026
  2. bradygaster commented on Aug 23, 2026

    @bradygaster
    CollaboratorAuthor

    Procedures triage brief — Phase 4 distribution/docs

    Owner & rationale

    Owner: PAO (squad:pao). This is user-facing distribution and documentation. PAO should own wording; Booster/FIDO should supply the final enforcement facts.

    Files in scope

    Verified existing paths:

    • docs\src\content\docs\guide\gh-aw.md
    • workflows\squad.md
    • workflows\squad-implement-worker.md
    • workflows\shared\squad.md

    Implementation must first research the exact gh aw add install/template source; no verified existing CLI template path for workflows*.md exists under packages\ today.

    Prompt-budget impact

    No expected workflows\squad.md growth: +0 KB. Documentation/install changes should not add router prompt text; if they do, they spend against the same ~35.6–37.6 KB remaining headroom.

    Dependencies

    Verification bar

    Docs validation must fail if the guide still says no /squad review exists after #1733, if the command table omits /squad review, or if gh aw add/install output omits the review workflow. A prose-only update without an install smoke check is not enough.

    Out of scope

    Implementing review, enforcement, or remediation behavior.

    Session-stall guard

    Before starting: this repo has phantom CRLF diffs (#1793). If git status shows files modified that you did not touch, run git diff --ignore-cr-at-eol. If that output is empty, the diff is line-ending churn, not real edits — run git add --renormalize . and continue. Do not halt and ask for confirmation; halting on phantom diffs is the documented cause of stuck sessions in this repo.

  3. added a commit that references this issue on Aug 25, 2026
    e363cb3
  4. added a commit that references this issue on Aug 25, 2026
    e2384a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    gh-awGitHub Agentic Workflows integrationgo:needs-researchNeeds investigationpriority:p2Next sprintsquadSquad triage inbox — Lead will assign to a membertriagedIssue has been triagedtype:docsDocumentation workwave:3-laterWave 3 — backlog, future

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions