Repository navigation
Phase 2: Enforce /squad review as a required check and gate epic relay on verdict #1734
Description
Parent: #1729
Depends on: #1733
Goal
Promote /squad review from advisory to enforcing, once Phase 1 has produced enough real review output to judge quality.
Acceptance criteria
- Set
inlined-imports: trueand pin a stable job name so a repository ruleset can require the check. - Required status check
Squad Review / reviewenabled ondevfirst, thenmainafter a soak period. - Epic merge relay in
workflows/squad-implement-worker.mdrefuses to advance to the next child when the merged PR carried an unresolvedREQUEST_CHANGESverdict from the reviewer. - A documented, auditable override path for the case where the reviewer is wrong and a human needs to proceed anyway.
Notes
Two ordering constraints:
- Ruleset checks need
inlined-imports: trueto resolve reliably, so that flag change belongs here rather than in Phase 1. - Gating the epic relay is the change that actually makes review part of the lifecycle rather than a bolt-on. Without it, review can request changes while the epic marches on to the next child.
Do not enable the required check until Phase 1 has been running advisory long enough to show the reviewer is not producing false REQUEST_CHANGES verdicts at a rate that would stall the pipeline.
Activity
github-actions commentedon Aug 23, 2026
📋 Assigned to Booster (CI/CD Engineer)
Issue: #1734 — Phase 2: Enforce /squad review as a required check and gate epic relay on verdict
Booster will pick this up in the next Copilot session.
24 remaining items
github-actions commentedon Sep 24, 2026
📋 Assigned to agentic-workflows-dev (Agentic Workflows Engineer)
Issue: #1734 — Phase 2: Enforce /squad review as a required check and gate epic relay on verdict
agentic-workflows-dev will pick this up in the next Copilot session.
bradygaster commentedon Sep 28, 2026
Implementation is tracked by #2096, whose closing keyword has been changed to
Implements #1734. Keep this issue open after merge until a private consumer fixture proves the exact-headSquad Reviewcheck, logical author/reviewer separation, relay gating, SHA deduplication, and the documented rollout/soak gate.fix(gh-aw): enforce independent Squad review and gate epic relay
test(gh-aw): reconcile reviewed topology after final restack
bradygaster commentedon Sep 29, 2026
Implementation milestone: #2096 merged into dev as da7861d after exact-head independent review, CLEAN state, and required test + gh-aw strict compile success. Keep this issue open until the private consumer full-lifecycle fixture records the exact-head Squad Review check, logical reviewer separation, relay/deduplication behavior, and the documented rollout/soak.
bradygaster commentedon Sep 29, 2026
Reopened because merge automation closed this issue before the documented consumer evidence and rollout/soak gates were satisfied. The implementation is merged; hosted acceptance and policy rollout remain.
bradygaster commentedon Sep 29, 2026
Post-#2105 reconciliation
The stable
Squad Review / reviewcontract and fail-closed dedicated-App design are merged through29e69f53. Closure still requires the real dedicated integration ID, integration-bound required check, hosted relay/dedupe/override proof, and soak. Those cannot begin until #2103 provisionssquad-review-authorityand the reviewer App. Keep open; the earlier auto-closure was premature.chore(release): promote dev to main (v1.1.0) (#2241)