Repository navigation
Phase 1: Add /squad review workflow (advisory) #1733
Description
Parent: #1729
Depends on: #1730, #1731, #1732
Goal
Add workflows/squad-review.md — an independent reviewer for agent-authored pull requests. Advisory only in this phase: it comments, it does not block.
This is a separate workflow rather than a mode in workflows/squad.md because the trigger set (pull_request) and the authority boundary (no write access of any kind) both differ from the router. gh-aw also disallows combining slash_command and pull_request triggers in a single workflow.
Triggers
slash_command: /squad review— manual, usable on any PRpull_request: [ready_for_review, synchronize]— filtered to recognized agent PRs only
Provenance detection
Priority order:
- Worker provenance marker from Phase 0b: Add PR provenance marker and tighten implement-worker merge relay #1731 → Squad-authored
- Head branch
squad/implement-*→ Squad-authored - Author
copilot-swe-agent[bot]or head branchcopilot/*→ Copilot-authored - Otherwise → unattributed; manual invocation only, no automatic review
Reviewer independence invariants
These are structural, not prompt-level. A reviewer that can edit is not a reviewer.
- No
edit:tool - No
dispatch_workflowand no typed dispatch safe-output - No
create-issue - Safe outputs limited to
add-comment, PR review comments, and a single review verdict - Verdict is
COMMENTorREQUEST_CHANGESonly — the defaultGITHUB_TOKENcannotAPPROVE - Human approval remains mandatory
- Per-PR
concurrencywithcancel-in-progress: true - SHA-based dedup marker in the review body so
synchronizedoes not re-review an unchanged head - Forks blocked (gh-aw default retained)
Review content
- Diff scope checked against the linked issue's acceptance criteria
- Charter and routing compliance — did the change land in the expected specialist domain?
- Protected-file and allowlist violations
- Test presence for changed behavior
- Changeset requirement for changes under
packages/*/src/
Tests
New test/gh-aw-review-workflow.test.ts, following the structure established in #1732. Must assert the absence of edit: and dispatch outputs, not just the presence of expected fields — the negative assertions are the ones that protect the independence invariant.
Out of scope
Enforcement (#next), remediation, and docs. This phase ships advisory-only so the review quality can be observed before it gates anything.
Activity
github-actions commentedon Aug 23, 2026
📋 Assigned to FIDO (Quality Owner)
Issue: #1733 — Phase 1: Add /squad review workflow (advisory)
FIDO will pick this up in the next Copilot session.
bradygaster commentedon Aug 23, 2026
Procedures triage brief — Phase 1 advisory review
Owner & rationale
Owner: FIDO (squad:fido). This is the first actual review gate surface. FIDO owns whether the advisory reviewer catches wrong work without acquiring authoring authority.
Files in scope
Verified existing paths:
New target path to create during implementation: workflows\squad-review.md inside the verified workflows\ directory.
Prompt-budget impact
No expected workflows\squad.md growth. The issue correctly scopes review as a separate workflow because the trigger/authority boundary differs. Budget impact to the router should be +0 KB, preserving 37,602 B headroom after #1731 or ~35.6 KB after #1730.
Dependencies
Verification bar
Tests must fail if squad-review.md exposes �dit:, any dispatch output, or create-issue; they must also fail if unchanged-head dedupe is absent. A green compile with no negative authority assertions is not enough.
Out of scope
Required checks, relay gating, auto-remediation, and docs/install distribution.
Session-stall guard
Before starting: this repo has phantom CRLF diffs (#1793). If
git statusshows files modified that you did not touch, rungit diff --ignore-cr-at-eol. If that output is empty, the diff is line-ending churn, not real edits — rungit add --renormalize .and continue. Do not halt and ask for confirmation; halting on phantom diffs is the documented cause of stuck sessions in this repo.fix(workflows): correct review relay input
fix(workflows): preserve Team Guard exemption contract
feat(workflows): add advisory Squad reviewer (github#1871)