Repository navigation
Description
Parent: #1729
Problem
Two testing gaps that make it unsafe to add a third workflow:
gh aw compilesilently skips.test/gh-aw-quality.test.ts(~line 614) skips the compile test when thegh awbinary is unavailable. In CI this means a workflow that does not compile can merge green.- Implement-worker tests are string assertions.
test/gh-aw-implement-workflow.test.tsis five regex/substring checks over markdown. It does not assert the worker's actual permission surface, tool allowlist, or trigger set — exactly the properties that matter for an authority-boundary workflow.
There is also no guard on the compiled prompt budget. Current source sum is roughly 74 KB against a ceiling near 100 KB; adding a review workflow narrows that margin.
Scope
test/gh-aw-quality.test.ts, test/gh-aw-implement-workflow.test.ts, and CI configuration.
Acceptance criteria
-
gh awis installed in CI and the compile test fails rather than skips when the binary is missing. - A prompt-budget check warns at ≥ 85 KB and fails at the hard ceiling.
- Implement-worker tests assert, structurally rather than by substring: declared triggers, presence of
edit:, the file allowlist,protected-files: request_review,allowed-branches, issue-scoped concurrency, andmax: 1on PR creation. - The resulting test shape is reusable as the template for the review workflow's tests.
Notes
This is the issue that establishes the pattern the review workflow will mirror, so it is worth landing before Phase 1 rather than alongside it.
Scope Narrowed — Compile Gate Only (2026-08-20 triage)
FIDO's triage split this issue into three verdicts:
- SHIP-NOW (this issue): Add
gh extension install github/gh-awtosquad-ci.yml'stestjob so the compile test actually runs in CI. - CLOSED — prompt-budget gate: Already done.
test/gh-aw-quality.test.ts:637-669enforces the 100 KB ceiling and >5 KB headroom guard. Ships with everynpm test. - CLOSED — string-assertion replacement: Too vague to action. Tests are already substantially structural (parser helpers throughout:
extractFrontmatter,extractSafeOutputs,extractModeTable,extractInlineSkills).
This issue now tracks the compile gate only.
Goal and Success Criteria
Goal: Make gh aw compile an actual CI gate — one that fails the squad-ci.yml test job when any squad workflow fails to compile, instead of silently skipping because gh aw is never installed in that job.
SC-1 — Install command present in CI job.
squad-ci.yml's test job contains gh extension install github/gh-aw before the step that invokes the compile test. Fails if that line is absent from the job.
SC-2 — Compile test no longer skips in CI.
test/gh-aw-quality.test.ts:978's it.skipIf(!ghAwAvailable) guard resolves to a running test (not a skip) in a CI run after this fix. Fails if the test still appears as skipped in CI logs.
SC-3 — A broken workflow fails the gate.
A workflows/squad.md with a deliberately introduced compile error (missing required field, invalid YAML, broken skill block) causes gh aw compile to exit non-zero and the CI test job to report a failure. Fails if a workflow with a compile error merges green through CI.
Activity
github-actions commentedon Aug 17, 2026
📋 Assigned to FIDO (Quality Owner)
Issue: #1732 — Phase 0c: Make gh aw compile non-skippable, add prompt-budget gate, replace string-assertion workflow tests
FIDO will pick this up in the next Copilot session.
fix(ci): install gh-aw extension in test job to make compile gate non…