Skip to content

DigestAuth will raise exception if non-replayble request is passed #670 - #685

Merged
florimondmanca merged 9 commits into
encode:masterfrom
kousikmitra:master
Jan 4, 2020
Merged

florimondmanca merged 9 commits into
encode:masterfrom
kousikmitra:master

Conversation

@kousikmitra

@kousikmitra kousikmitra commented Dec 26, 2019 •

Copy link
Copy Markdown
Contributor

Reference to PR #684

Fixes #670

DigestAuth will now raise RequestBodyUnavailable exception if a non-replayable request is passed to its __call__ method.

Feedback will be appreciated. :)

@florimondmanca florimondmanca left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Makes me think we may want to repurpose RedirectBodyUnavailable.

Comment thread httpx/exceptions.py Outdated
@florimondmanca

Copy link
Copy Markdown
Contributor

@kousikmitra Issued #690. Feel free to have a look!

@florimondmanca florimondmanca left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 🌟 Thank you!

@florimondmanca
florimondmanca merged commit 0ed0314 into encode:master Jan 4, 2020
Kludex referenced this pull request in pydantic/httpx2 May 11, 2026
* Version 0.17.1

* Improve changelog

* Update CHANGELOG.md

---------

Co-authored-by: Tom Christie <tom@tomchristie.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

DigestAuth should raise a clear error if the request cannot replay.

2 participants