Skip to content

Repurpose RedirectBodyUnavailable exception as RequestBodyUnavailable - #690

Merged
florimondmanca merged 1 commit into
masterfrom
request-body-unavailable
Jan 3, 2020
Merged

florimondmanca merged 1 commit into
masterfrom
request-body-unavailable

Conversation

@florimondmanca

Copy link
Copy Markdown
Contributor

Prompted by #685 (comment)

This PR generalizes the semantics of RedirectBodyUnavailable so that it fits situations when we can't replay a request stream that aren't related to redirection (e.g. Digest Auth in #685).

@florimondmanca florimondmanca added the refactor Issues and PRs related to code refactoring label Dec 27, 2019
@florimondmanca
florimondmanca requested a review from a team December 27, 2019 23:31
@florimondmanca florimondmanca changed the title Repurpose RedirectBodyUnavailable as RequestBodyUnavailable Repurpose RedirectBodyUnavailable exception as RequestBodyUnavailable Dec 28, 2019
@florimondmanca

Copy link
Copy Markdown
Contributor Author

@tomchristie Thoughts on this one?

@lovelydinosaur

Copy link
Copy Markdown
Member

I'm a yes on it, but we should probably have it in the same PR as the digest fix?

@florimondmanca

Copy link
Copy Markdown
Contributor Author

Alright, merging so that we can bring the changes back in #685 via a merge from master. :-)

@florimondmanca
florimondmanca merged commit 910aa90 into master Jan 3, 2020
@florimondmanca
florimondmanca deleted the request-body-unavailable branch January 3, 2020 21:25
Kludex referenced this pull request in pydantic/httpx2 May 11, 2026
* Fan out loggers

* Updated CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Issues and PRs related to code refactoring

Development

Successfully merging this pull request may close these issues.

2 participants