Skip to content

DigestAuth should raise a clear error if the request cannot replay. #670

Closed

Description

@lovelydinosaur

Our DigestAuth implementation cannot work with non-replayable requests.
We ought to raise a nice clear error if request.stream.is_replayable is not True.

Activity

  1. lovelydinosaur commented on Dec 21, 2019

    @lovelydinosaur
    MemberAuthor

    See the client redirect code for an equivelent case with redirects.

    Potentially a reasonable first issue.

  2. kousikmitra commented on Dec 23, 2019

    @kousikmitra
    Contributor

    @tomchristie hey can I work on this?

  3. florimondmanca commented on Dec 23, 2019

    @florimondmanca
    Contributor

    @kousikmitra Feel free to! We don’t tend to assign people to issues so feel free to go ahead and open a PR when you’d like to get feedback. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issueGood for newcomersuser-experienceEnsuring that users have a good experience using the library

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions