Repository navigation
Allow default+override timeout style - #593
Merged
Merged
Conversation
lovelydinosaur
changed the title
florimondmanca
approved these changes
Dec 4, 2019
florimondmanca
left a comment
florimondmanca
left a comment
Contributor
There was a problem hiding this comment.
Nice :) I like the improved copy as well.
| * The **read timeout** specifies the maximum duration to wait for a chunk of | ||
| data to be received (for example, a chunk of the response body). If HTTPX is | ||
| unable to receive data within this time frame, a `ReadTimeout` exception is raised. | ||
| The default behavior is to raise a `RequestException` after 5 seconds of |
Contributor
There was a problem hiding this comment.
Isn鈥檛 it a RequestTimeout?
Member
Author
There was a problem hiding this comment.
Thanks!
What do we actually want the base timeout exception to be called? TimeoutError is a python built-in, so I guess we've got...
TimeoutExceptionBaseTimeoutRequestTimeout
?...
Contributor
There was a problem hiding this comment.
I like TimeoutException best: explicit, boring and unsurprising. (RequestTimeout has an odd vibe to it that I can't really explain, and BaseTimeout sounds like a base class.)
Member
Author
|
Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow eg.
Timeout(5.0, pool_timeout=None)Closes #435, Closes #578