Skip to content

Repository navigation

TimeoutConfig improvements. #578

Closed
#593
Closed
TimeoutConfig improvements.#578
#593
Labels
enhancementNew feature or requestuser-experienceEnsuring that users have a good experience using the library
Milestone
v1.0

Description

@lovelydinosaur
lovelydinosaur
opened on Nov 30, 2019

  1. TimeoutConfig(5.0) should really just be Timeout(5.0). We don't want to break the API prior to 1.0 so I guess let's switch it to Timeout but have a TimeoutConfig = Timeout synonym.

  2. Right now we either support Timeout(5.0) or Timeout(read_timeout=5.0), however we should actually support a style that provides the default case, and the exceptional cases. Eg...

# Connect, Read, Write have a 5 second timeout. Pool acquiry never times out.
timeout = httpx.Timeout(5.0, pool_timeout=None)
client = Client(timeout=timeout)

Activity

  1. lovelydinosaur
    added this to the v1.0 milestone on Nov 30, 2019
  2. lovelydinosaur
    added
    enhancementNew feature or request
    user-experienceEnsuring that users have a good experience using the library
    on Dec 3, 2019
  3. lovelydinosaur
    closed this as completedin #593on Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestuser-experienceEnsuring that users have a good experience using the library

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions