Fine-tuning timeouts from the default timeout config #435

Activity

1. florimondmanca

   added

   questionFurther information is requestedFurther information is requested

   on Oct 3, 2019
2. sethmlarson commented on Oct 3, 2019

   

   sethmlarson

   on Oct 3, 2019

   Contributor

   More actions

   What about making TimeoutConfig(read_timeout=1) result in 5, 1, 5 instead of None, 1, None? Then you have to be explicit about the other two if you truly want "None".
3. lovelydinosaur commented on Oct 4, 2019

   

   lovelydinosaur

   on Oct 4, 2019

   Last edited by lovelydinosaur

   Member

   More actions

   Simplest question is, what do we want this to return?...

   >>> httpx.TimeoutConfig()

   I think we should probably switch things around so that it'll give you TimeoutConfig(timeout=5) rather than TimeoutConfig(timeout=None), right?

   I guess we want something like this...

   DEFAULT_TIMEOUT = 5
   UNSET = object()
   
   class TimeoutConfig:
       def __init__(
           self,
           timeout: TimeoutTypes = DEFAULT_TIMEOUT,
           *,
           connect_timeout: float = UNSET,
           read_timeout: float = UNSET,
           write_timeout: float = UNSET,
       ):
           self.connect_timeout = timeout if connect_timeout is UNSET else connect_timeout
           self.read_timeout = timeout if read_timeout is UNSET else read_timeout
           self.write_timeout = timeout if connect_timeout is UNSET else write_timeout
           ...
4. florimondmanca commented on Oct 4, 2019

   

   florimondmanca

   on Oct 4, 2019

   Last edited by florimondmanca

   ContributorAuthor

   More actions

   And so we'd have:

   >>> # Override one of the timeouts.
   >>> httpx.TimeoutConfig(read_timeout=1)
   TimeoutConfig(connect_timeout=5, read_timeout=1, write_timeout=5)
   >>> # Disable timeouts.
   >>> httpx.TimeoutConfig(timeout=None)
   TimeoutConfig(connect_timeout=None, read_timeout=None, write_timeout=None)
   >>> # Set all timeouts to 3 seconds but disable read.
   >>> httpx.TimeoutConfig(timeout=3, read_timeout=None)
   TimeoutConfig(connect_timeout=3, read_timeout=None, write_timeout=3)

   This looks like a nice approach to me. I suppose we'd get rid of DEFAULT_TIMEOUT_CONFIG entirely and use TimeoutConfig() instead?

   👍React with 👍1Reacted by Seth Larson
5. lovelydinosaur

   closed this as completedin #593on Dec 5, 2019