Skip to content

Add test script - #451

Merged
florimondmanca merged 1 commit into
masterfrom
tooling/test-script
Oct 12, 2019
Merged

florimondmanca merged 1 commit into
masterfrom
tooling/test-script

Conversation

@florimondmanca

@florimondmanca florimondmanca commented Oct 5, 2019 •

Copy link
Copy Markdown
Contributor

Prompted by #399 (comment)

Running

$ scripts/test

runs the test suite and runs the check session.

I made it so that the test suite only for the current Python version is run (e.g. 3.7), but we could also run $ nox -s test so that all available Python versions are tested (e.g. all of 3.6, 3.7 and 3.8 if they're detected as available by nox). This is mostly because running tests against all Python versions can get very long, esp. because virtualenvs aren't reused. Thoughts?

@florimondmanca

Copy link
Copy Markdown
Contributor Author

I'm also wondering — what should we do about the contributing docs, since they currently recommend using $ nox -s test?

@pquentin

pquentin commented Oct 6, 2019

Copy link
Copy Markdown
Contributor

Would it help to configure nox to reuse virtual environments? There are various places where it can be done: https://nox.thea.codes/en/stable/config.html

@florimondmanca

Copy link
Copy Markdown
Contributor Author

@pquentin We actually reuse virtualenvs in all other nox sessions, but not in test. I think reusing would be OK in that case too though. We can always --no-reuse-existing-virtualenvs on the command line. I'll submit a separate PR for that. :)

Comment thread docs/contributing.md Outdated
@florimondmanca
florimondmanca merged commit 5e4f54d into master Oct 12, 2019
@florimondmanca
florimondmanca deleted the tooling/test-script branch October 12, 2019 16:14
Kludex referenced this pull request in pydantic/httpx2 May 11, 2026
Bumps [coverage](https://github.com/nedbat/coveragepy) from 5.5 to 6.2.
- [Release notes](https://github.com/nedbat/coveragepy/releases)
- [Changelog](https://github.com/nedbat/coveragepy/blob/master/CHANGES.rst)
- [Commits](coveragepy/coveragepy@coverage-5.5...6.2)

---
updated-dependencies:
- dependency-name: coverage
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tom Christie <tom@tomchristie.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants