Skip to content

Add hints for debugging CI issues - #399

Merged
sethmlarson merged 5 commits into
masterfrom
issue-311
Oct 10, 2019
Merged

sethmlarson merged 5 commits into
masterfrom
issue-311

Conversation

@sethmlarson

Copy link
Copy Markdown
Contributor

Closes #311

@florimondmanca florimondmanca left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Screenshots would bring an extra oompf, can we consider adding some?

Comment thread .github/CONTRIBUTING.md Outdated
Comment thread .github/CONTRIBUTING.md Outdated
Comment thread docs/contributing.md
Co-Authored-By: Florimond Manca <florimond.manca@gmail.com>
Comment thread docs/contributing.md
@sethmlarson

Copy link
Copy Markdown
Contributor Author

Added some images, would like another review @florimondmanca or @yeraydiazdiaz! :)

@florimondmanca

Copy link
Copy Markdown
Contributor

Will try to take a look soon @sethmlarson. A bit short on time for the next few days though.

@florimondmanca florimondmanca mentioned this pull request Oct 5, 2019

@florimondmanca florimondmanca left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems good for merging to me!

@florimondmanca florimondmanca left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor typo.

Comment thread docs/contributing.md Outdated
@sethmlarson
sethmlarson merged commit a80c432 into master Oct 10, 2019
@sethmlarson
sethmlarson deleted the issue-311 branch October 10, 2019 12:05
@sethmlarson

Copy link
Copy Markdown
Contributor Author

Thanks @florimondmanca!

Kludex referenced this pull request in pydantic/httpx2 May 11, 2026
Bumps [furo](https://github.com/pradyunsg/furo) from 2021.7.31b41 to 2021.8.31.
- [Release notes](https://github.com/pradyunsg/furo/releases)
- [Changelog](https://github.com/pradyunsg/furo/blob/main/docs/changelog.md)
- [Commits](pradyunsg/furo@2021.07.31.beta41...2021.08.31)

---
updated-dependencies:
- dependency-name: furo
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tom Christie <tom@tomchristie.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Contributing Guide - Helping our users resolve build failures.

4 participants