Skip to content

Make nox always reuse virtualenvs by default - #460

Merged
florimondmanca merged 3 commits into
masterfrom
tooling/nox-reuse-venvs
Oct 9, 2019
Merged

florimondmanca merged 3 commits into
masterfrom
tooling/nox-reuse-venvs

Conversation

@florimondmanca

Copy link
Copy Markdown
Contributor

Prompted by #451 (comment)

Comment thread mkdocs.yml Resolved
@florimondmanca
florimondmanca requested a review from a team October 6, 2019 11:13

@sethmlarson sethmlarson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one idea.

Comment thread docs/contributing.md Resolved
@florimondmanca
florimondmanca force-pushed the tooling/nox-reuse-venvs branch from fadaf50 to dfcace8 Compare October 9, 2019 18:10
@florimondmanca
florimondmanca merged commit 7361d60 into master Oct 9, 2019
@florimondmanca
florimondmanca deleted the tooling/nox-reuse-venvs branch October 9, 2019 18:22
Comment thread mkdocs.yml
markdown_extensions:
- admonition
- codehilite
- pymdownx.superfences

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing this crept into this PR by accident?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woops. I used to need it for the nested code block in the updated contributing guide, which in the end didn’t make it. So yep, this is technically superfluous wrt this PR. (I’ll argue it’s a nice addition though, as it was blocking us from writing code blocks in admonitions.)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. Ideally let's defer until we've got somewhere we needed. (Tho it's a small issue so not overly fussed about it in the meantime)

Comment thread noxfile.py
@nox.session
def docs(session):
session.install("mkdocs", "mkdocs-material")
session.install("--upgrade", "mkdocs", "mkdocs-material", "pymdown-extensions")

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here - I don't think we need pymdown-extensions at the moment?

Kludex referenced this pull request in pydantic/httpx2 May 11, 2026
Bumps [twine](https://github.com/pypa/twine) from 3.6.0 to 3.7.1.
- [Release notes](https://github.com/pypa/twine/releases)
- [Changelog](https://github.com/pypa/twine/blob/main/docs/changelog.rst)
- [Commits](pypa/twine@3.6.0...3.7.1)

---
updated-dependencies:
- dependency-name: twine
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tom Christie <tom@tomchristie.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants