Repository navigation
fix: correct the spread order for http_emitter options - #225
lholmquist wants to merge 2 commits into
Conversation
fixes: cloudevents#223 Signed-off-by: Lucas Holmquist <lholmqui@redhat.com>
Signed-off-by: Lucas Holmquist <lholmqui@redhat.com>
|
While this should be a fairly straightforward change, i'm running into issues related to Typescript when adding in the tests. I know basic's, but I'm not sure how to proceed when trying to declare the type for a variable object that uses the spread operator. @grant perhaps you have some insight, since from my reading of other issues, you were the most vocal for adding typescript support. Thanks in advance Also cc @lance |
|
That's a bad bug. Thanks for the PR! I too have seen many TypeScript issues due to the fact this repo is half js, half ts, which causes issues with types due to inferred types. I've added an issue here: #203 |
|
From my side there is no urgency. Anyway, thanks for your great work with CE and this SDK! |
|
closing this since it will be fixed in #226 |
fixes: #223
I would like to add a test for this, but I think some type definitions need to be added so typescript doesn't complain about me trying to pass in more options in the send method. Keeping as Draft for now
Signed-off-by: Lucas Holmquist lholmqui@redhat.com