You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It doesn't make sense to have some .ts files and some .js files in the repo. Although it will work, it is common to just rename the extension of all files to .ts.
Hi @grant - I have actually been working on a complete rewrite of the entire module that does a lot more than just renaming the files to have a .ts extension. And it's 100% TS. I hope to have at least a draft PR of this ready this week.
https://www.npmjs.com/~lanceball now has full permissions for module cloudevents.
Feel free to mirror previous versions/use that module for publishing.
was it actually decided that this module is changing names? I thought that was an ongoing discussion in #215 ?
so getting back to the issue of #225, if things are being re-written, should we even worry about the test and just fix the issue now, so the users who reported the bug can do what they need to do and the typescript stuff will fix itself once the module is re-written?
Activity
grant commentedon Jun 15, 2020
Hey @lance, do you have any thoughts around this? I think there are a few bugs with keeping the hybrid mode that make it hard to contribute.
lance commentedon Jun 15, 2020
Hi @grant - I have actually been working on a complete rewrite of the entire module that does a lot more than just renaming the files to have a
.tsextension. And it's 100% TS. I hope to have at least a draft PR of this ready this week.grant commentedon Jun 15, 2020
OK, sounds good. Thanks for the update @lance.
The rewrite sounds great and could solve lots of issues.
lance commentedon Jun 15, 2020
I think we can probably consider renaming to 'cloudevents' as well with a 3.0.0 release
grant commentedon Jun 15, 2020
https://www.npmjs.com/~lanceball now has full permissions for module
cloudevents.Feel free to mirror previous versions/use that module for publishing.
lholmquist commentedon Jun 15, 2020
was it actually decided that this module is changing names? I thought that was an ongoing discussion in #215 ?
lholmquist commentedon Jun 16, 2020
so getting back to the issue of #225, if things are being re-written, should we even worry about the test and just fix the issue now, so the users who reported the bug can do what they need to do and the typescript stuff will fix itself once the module is re-written?